[coreboot-gerrit] Change in coreboot[master]: security/vboot: Split fwid.region build target

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/27884 )

Change subject: security/vboot: Split fwid.region build target
......................................................................


Patch Set 1: Code-Review+2

(2 comments)

https://review.coreboot.org/#/c/27884/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/27884/1//COMMIT_MSG@11
PS1, Line 11: objects are not invalidated when bumping the fwid.
> You assessment is correct, the target will only get created once and never touched again. […]
Okay, sorry, I think I overlooked the last line in here yesterday. So you want to replace the file and keep .config the same. Yeah, that should work.


https://review.coreboot.org/#/c/27884/1/src/security/vboot/Makefile.inc
File src/security/vboot/Makefile.inc:

https://review.coreboot.org/#/c/27884/1/src/security/vboot/Makefile.inc@232
PS1, Line 232: file
> I used the built in file function: https://www.gnu.org/software/make/manual/html_node/File-Function. […]
Oh, right, carry on then.



-- 
To view, visit https://review.coreboot.org/27884
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I955106efd648a75a1311f24ede46bd238d1517e0
Gerrit-Change-Number: 27884
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 07 Aug 2018 18:46:27 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180807/6a2da14e/attachment.html>