[coreboot-gerrit] Change in coreboot[master]: lib/edid.c: Avoid static analysis error for unused value

Richard Spiegel (Code Review) gerrit at coreboot.org
Tue Aug 7 17:46:58 CEST 2018


Richard Spiegel has uploaded a new patch set (#2). ( https://review.coreboot.org/27929 )

Change subject: lib/edid.c: Avoid static analysis error for unused value
......................................................................

lib/edid.c: Avoid static analysis error for unused value

Within procedure cea_hdmi_block, the variable "b" is used as an index into
a buffer of EDID bytes. Each time it's used, it's incremented, but the last
increment is not used and is causing a static analysis error. Add a printk
at the end, using variable "b", to avoid the static analysis error.

BUG=b:112253891
TEST=Build and boot grunt.

Change-Id: Ibd0b4a21bf82fcc46a627bc75564a850b7374989
Signed-off-by: Richard Spiegel <richard.spiegel at silverbackltd.com>
---
M src/lib/edid.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/27929/2
-- 
To view, visit https://review.coreboot.org/27929
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibd0b4a21bf82fcc46a627bc75564a850b7374989
Gerrit-Change-Number: 27929
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180807/4fff7eb6/attachment.html>


More information about the coreboot-gerrit mailing list