[coreboot-gerrit] Change in coreboot[master]: lib/edid.c: Avoid static analysis error for unused value

[Richard Spiegel (Code Review)]

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/27929


Change subject: lib/edid.c: Avoid static analysis error for unused value
......................................................................

lib/edid.c: Avoid static analysis error for unused value

Within procedure cea_hdmi_block, the variable "b" is used as an index into
a buffer of EDID bytes. Each time it's used, it's incremented, but the last
increment is not used and is causing a static analysis error. Add a printk
at the end, using variable "b", to avoid the static analysis error.

BUG=b:112253891
TEST=Build and boot grunt.

Change-Id: Ibd0b4a21bf82fcc46a627bc75564a850b7374989
Signed-off-by: Richard Spiegel <richard.spiegel at silverbackltd.com>
---
M src/lib/edid.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/27929/1

diff --git a/src/lib/edid.c b/src/lib/edid.c
index 7ad4136..747526e 100644
--- a/src/lib/edid.c
+++ b/src/lib/edid.c
@@ -817,7 +817,7 @@
 				 * (optionally: 3D_Detail_X and reserved)
 				 */
 			}
-
+		printk(BIOS_SPEW, "Next EDID byte %d\n", (9 +b));
 		}
 	}
 }

-- 
To view, visit https://review.coreboot.org/27929
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibd0b4a21bf82fcc46a627bc75564a850b7374989
Gerrit-Change-Number: 27929
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180807/79c055ce/attachment-0001.html>