[coreboot-gerrit] Change in coreboot[master]: security/vboot: Split fwid.region build target

[Raul Rangel (Code Review)]

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/27884 )

Change subject: security/vboot: Split fwid.region build target
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/27884/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/27884/1//COMMIT_MSG@11
PS1, Line 11: objects are not invalidated when bumping the fwid.
> I don't believe this, actually. […]
You assessment is correct, the target will only get created once and never touched again. This is the current behavior. When .config or Kconfig change we also need to blow away the $(obj) dir as well.

The coreboot ebuild currently passes along the VBOOT_FWID_VERSION via .config.
https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/refs/heads/master/sys-boot/coreboot/coreboot-9999.ebuild#166
This means we need to blow away essentially everything because the config.h changes on every build. By modifying the coreboot ebuild to write out fwid.version and not update the .config then the .config will remain constant when only making source changes. By modifying the ebuild to only re-run make oldconfig if the new.config != old.config then the config.h timestamp will not change either.

I'll get the patches for the ebuild uploaded soon. I need to clean them up.



-- 
To view, visit https://review.coreboot.org/27884
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I955106efd648a75a1311f24ede46bd238d1517e0
Gerrit-Change-Number: 27884
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Julius Werner <jwerner at chromium.org>
Gerrit-Comment-Date: Tue, 07 Aug 2018 14:18:17 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180807/ea9b182c/attachment.html>