[coreboot-gerrit] Change in coreboot[master]: cpu/intel/smm: Make sure SMRR base is aligned to SMRR size

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/27870 )

Change subject: cpu/intel/smm: Make sure SMRR base is aligned to SMRR size
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/27870/2/src/cpu/intel/smm/gen1/smmrelocate.c
File src/cpu/intel/smm/gen1/smmrelocate.c:

https://review.coreboot.org/#/c/27870/2/src/cpu/intel/smm/gen1/smmrelocate.c@180
PS2, Line 180: BIOS_WARNING
> warning or error?
looking at the description of both, it feels like BIOS_WARNING is better since it is expected to still work if SMRR is not set. Not sure to what extend TSEG is accessible accessible with SMRR being set, so it is a security issue at most.



-- 
To view, visit https://review.coreboot.org/27870
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48f55cdac5f4b16b9a8d7a8ef3a84918e756e315
Gerrit-Change-Number: 27870
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 07 Aug 2018 13:25:18 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180807/566fe258/attachment.html>