[coreboot-gerrit] Change in coreboot[master]: mb/intel/coffeelake: Enable 32MB rom compilation for Coffeelake U

Arthur Heymans (Code Review) gerrit at coreboot.org
Tue Aug 7 13:54:26 CEST 2018


Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/27905 )

Change subject: mb/intel/coffeelake: Enable 32MB rom compilation for Coffeelake U
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/27905/1/src/mainboard/intel/coffeelake_rvp/Kconfig
File src/mainboard/intel/coffeelake_rvp/Kconfig:

https://review.coreboot.org/#/c/27905/1/src/mainboard/intel/coffeelake_rvp/Kconfig@6
PS1, Line 6: BOARD_ROMSIZE_KB_32768
make sure the default for "config FMDFILE" points to the new 32M fmd file. (e.g. https://review.coreboot.org/#/c/coreboot/+/25084/15/src/mainboard/opencellular/rotundu/Kconfig)



-- 
To view, visit https://review.coreboot.org/27905
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I21431b7ac813781b12b95f80c6f8960a78caf4bc
Gerrit-Change-Number: 27905
Gerrit-PatchSet: 1
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela at intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Comment-Date: Tue, 07 Aug 2018 11:54:26 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180807/8a98148b/attachment.html>


More information about the coreboot-gerrit mailing list