[coreboot-gerrit] Change in coreboot[master]: cbmem: rename vdat to chromeos_acpi

Joel Kitching (Code Review) gerrit at coreboot.org
Tue Aug 7 08:53:21 CEST 2018


Hello build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/27888

to look at the new patch set (#3).

Change subject: cbmem: rename vdat to chromeos_acpi
......................................................................

cbmem: rename vdat to chromeos_acpi

There is a confusingly named section in cbmem called vdat.
This section holds a data structure called chromeos_acpi_t,
which exposes some system information to the Chrome OS
userland utility crossystem.

Within the chromeos_acpi_t structure, there is a member
called vdat.  This (currently) holds a VbSharedDataHeader.

Rename the outer vdat to chromeos_acpi to make its purpose
clear, and prevent the bizarreness of being able to access
vdat->vdat.

Additionally, disallow external references to the
chromeos_acpi data structure in gnvs.c.

BUG=b:112288216
TEST=emerge-eve coreboot, run on eve
CQ-DEPEND=CL:1164722

Signed-off-by: Joel Kitching <kitching at google.com>

Change-Id: Ia74e58cde21678f24b0bb6c1ca15048677116b2e
---
M payloads/libpayload/include/coreboot_tables.h
M payloads/libpayload/include/sysinfo.h
M payloads/libpayload/libc/coreboot.c
M src/arch/x86/smbios.c
M src/commonlib/include/commonlib/coreboot_tables.h
M src/lib/coreboot_table.c
M src/vendorcode/google/chromeos/gnvs.c
M src/vendorcode/google/chromeos/gnvs.h
8 files changed, 42 insertions(+), 36 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/27888/3
-- 
To view, visit https://review.coreboot.org/27888
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia74e58cde21678f24b0bb6c1ca15048677116b2e
Gerrit-Change-Number: 27888
Gerrit-PatchSet: 3
Gerrit-Owner: Joel Kitching <kitching at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180807/d4502b8f/attachment.html>


More information about the coreboot-gerrit mailing list