[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge/acpi.c: Fix plen usage

Richard Spiegel (Code Review) gerrit at coreboot.org
Mon Aug 6 20:06:39 CEST 2018


Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/27877


Change subject: soc/amd/stoneyridge/acpi.c: Fix plen usage
......................................................................

soc/amd/stoneyridge/acpi.c: Fix plen usage

In procedure generate_cpu_entries(), plen is first assigned a value of 6,
and used when calling acpigen_write_processor, then 0 is written to it,
but nex call to acpigen_write_processor uses a hardcoded 0 instead of plen.
Replace hardcoded 0 with plen.

BUG=b:112253891
TEST=Build and boot grunt.

Change-Id: I0258b19960b050e8da9d218ded3f1f3bfccad163
Signed-off-by: Richard Spiegel <richard.spiegel at silverbackltd.com>
---
M src/soc/amd/stoneyridge/acpi.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/27877/1

diff --git a/src/soc/amd/stoneyridge/acpi.c b/src/soc/amd/stoneyridge/acpi.c
index 5f9e792..25160d9 100644
--- a/src/soc/amd/stoneyridge/acpi.c
+++ b/src/soc/amd/stoneyridge/acpi.c
@@ -254,7 +254,7 @@
 	pcontrol_blk = 0;
 	plen = 0;
 	for (cpu = 1; cpu < cores; cpu++) {
-		acpigen_write_processor(cpu, pcontrol_blk, 0);
+		acpigen_write_processor(cpu, pcontrol_blk, plen);
 		acpigen_pop_len();
 	}
 }

-- 
To view, visit https://review.coreboot.org/27877
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0258b19960b050e8da9d218ded3f1f3bfccad163
Gerrit-Change-Number: 27877
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180806/70d802f6/attachment.html>


More information about the coreboot-gerrit mailing list