[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge: Set undocumented misc register

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/27876 )

Change subject: soc/amd/stoneyridge: Set undocumented misc register
......................................................................


Patch Set 1:

(4 comments)

https://review.coreboot.org/#/c/27876/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/27876/1//COMMIT_MSG@7
PS1, Line 7: Set undocumented misc register
Maybe change this to what it does?  This description is just ASKING for trouble.

 soc/amd/stoneyridge: Prevent reboot in romstage


https://review.coreboot.org/#/c/27876/1/src/soc/amd/stoneyridge/southbridge.c
File src/soc/amd/stoneyridge/southbridge.c:

https://review.coreboot.org/#/c/27876/1/src/soc/amd/stoneyridge/southbridge.c@609
PS1, Line 609: |
You don't really need to or the bit in either here or below, do you?


https://review.coreboot.org/#/c/27876/1/src/soc/amd/stoneyridge/southbridge.c@614
PS1, Line 614: 	uint32_t reg = misc_read32(0x50);
This might be the spot to mention that it's an undocumented register.


https://review.coreboot.org/#/c/27876/1/src/soc/amd/stoneyridge/southbridge.c@615
PS1, Line 615: (1 << 16)
use BIT(16) from types.h?



-- 
To view, visit https://review.coreboot.org/27876
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie19f7a14deaef45ac63156bec6946273c1b9447e
Gerrit-Change-Number: 27876
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Garrett Kirkendall <garrett.kirkendall at amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 06 Aug 2018 16:32:11 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180806/7334b6ba/attachment.html>