[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Add support for LPDDR4 nWR setting

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Mon Aug 6 17:32:59 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27850 )

Change subject: soc/intel/apollolake: Add support for LPDDR4 nWR setting
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/27850/2/src/soc/intel/apollolake/meminit.c
File src/soc/intel/apollolake/meminit.c:

https://review.coreboot.org/#/c/27850/2/src/soc/intel/apollolake/meminit.c@361
PS2, Line 361:  	*/
code indent should use tabs where possible


https://review.coreboot.org/#/c/27850/2/src/soc/intel/apollolake/meminit.c@361
PS2, Line 361:  	*/
please, no space before tabs



-- 
To view, visit https://review.coreboot.org/27850
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1147538f72f4e2f14e32f3657c05f1f505a56fbf
Gerrit-Change-Number: 27850
Gerrit-PatchSet: 2
Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Kane Chen <kane.chen at intel.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 06 Aug 2018 15:32:59 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180806/e0434b18/attachment.html>


More information about the coreboot-gerrit mailing list