[coreboot-gerrit] Change in coreboot[master]: cpu/intel/smm: Make sure SMRR base is aligned to SMRR size

Felix Held (Code Review) gerrit at coreboot.org
Mon Aug 6 16:48:49 CEST 2018


Felix Held has posted comments on this change. ( https://review.coreboot.org/27870 )

Change subject: cpu/intel/smm: Make sure SMRR base is aligned to SMRR size
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/27870/1/src/cpu/intel/smm/gen1/smmrelocate.c
File src/cpu/intel/smm/gen1/smmrelocate.c:

https://review.coreboot.org/#/c/27870/1/src/cpu/intel/smm/gen1/smmrelocate.c@176
PS1, Line 176: (1 << 20)
is it intended hat you replace tseg_size with this constant?



-- 
To view, visit https://review.coreboot.org/27870
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48f55cdac5f4b16b9a8d7a8ef3a84918e756e315
Gerrit-Change-Number: 27870
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Comment-Date: Mon, 06 Aug 2018 14:48:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180806/c5a1bc44/attachment.html>


More information about the coreboot-gerrit mailing list