[coreboot-gerrit] Change in coreboot[master]: nb/intel/*: Account for cbmem_top alignment

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Mon Aug 6 16:13:58 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27871 )

Change subject: nb/intel/*: Account for cbmem_top alignment
......................................................................


Patch Set 1:

(4 comments)

https://review.coreboot.org/#/c/27871/1/src/northbridge/intel/gm45/northbridge.c
File src/northbridge/intel/gm45/northbridge.c:

https://review.coreboot.org/#/c/27871/1/src/northbridge/intel/gm45/northbridge.c@142
PS1, Line 142: 	/* cbmem_top can be shifted downwards due to aligment.
'aligment' may be misspelled - perhaps 'alignment'?


https://review.coreboot.org/#/c/27871/1/src/northbridge/intel/i945/northbridge.c
File src/northbridge/intel/i945/northbridge.c:

https://review.coreboot.org/#/c/27871/1/src/northbridge/intel/i945/northbridge.c@106
PS1, Line 106: 	/* cbmem_top can be shifted downwards due to aligment.
'aligment' may be misspelled - perhaps 'alignment'?


https://review.coreboot.org/#/c/27871/1/src/northbridge/intel/pineview/northbridge.c
File src/northbridge/intel/pineview/northbridge.c:

https://review.coreboot.org/#/c/27871/1/src/northbridge/intel/pineview/northbridge.c@106
PS1, Line 106: 	/* cbmem_top can be shifted downwards due to aligment.
'aligment' may be misspelled - perhaps 'alignment'?


https://review.coreboot.org/#/c/27871/1/src/northbridge/intel/x4x/northbridge.c
File src/northbridge/intel/x4x/northbridge.c:

https://review.coreboot.org/#/c/27871/1/src/northbridge/intel/x4x/northbridge.c@104
PS1, Line 104: 	/* cbmem_top can be shifted downwards due to aligment.
'aligment' may be misspelled - perhaps 'alignment'?



-- 
To view, visit https://review.coreboot.org/27871
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifab37b0003f09a680024d5b155ab0bb157920952
Gerrit-Change-Number: 27871
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 06 Aug 2018 14:13:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180806/2ac37d25/attachment.html>


More information about the coreboot-gerrit mailing list