[coreboot-gerrit] Change in coreboot[master]: exception: Fix segment error code mask

Patrick Georgi (Code Review) gerrit at coreboot.org
Mon Aug 6 09:56:12 CEST 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/27812 )

Change subject: exception: Fix segment error code mask
......................................................................

exception: Fix segment error code mask

The segment error descriptor is actually 13 bits long.

BUG=b:109749762
TEST=Verified by causing a segment error

Change-Id: I3439f9ce1e8cf0c472c4eb82d74a787718c9609f
Signed-off-by: Raul E Rangel <rrangel at chromium.org>
Reviewed-on: https://review.coreboot.org/27812
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Martin Roth <martinroth at google.com>
---
M payloads/libpayload/arch/x86/exception.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved



diff --git a/payloads/libpayload/arch/x86/exception.c b/payloads/libpayload/arch/x86/exception.c
index f6bb8c9..b562660 100644
--- a/payloads/libpayload/arch/x86/exception.c
+++ b/payloads/libpayload/arch/x86/exception.c
@@ -59,7 +59,7 @@
 
 static void print_segment_error_code(u32 code)
 {
-	printf("%#x - descriptor %#x in the ", code, (code >> 3) & 0x1f);
+	printf("%#x - descriptor %#x in the ", code, (code >> 3) & 0x1FFF);
 	if (code & (0x1 << 1)) {
 		printf("IDT");
 	} else {

-- 
To view, visit https://review.coreboot.org/27812
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3439f9ce1e8cf0c472c4eb82d74a787718c9609f
Gerrit-Change-Number: 27812
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180806/24194bfe/attachment.html>


More information about the coreboot-gerrit mailing list