[coreboot-gerrit] Change in coreboot[master]: southbridge/intel/bd82x6x/Kconfig: Do not include any IFD by default
Felix Held (Code Review)
gerrit at coreboot.org
Sun Aug 5 21:57:59 CEST 2018
Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/27218 )
Change subject: southbridge/intel/bd82x6x/Kconfig: Do not include any IFD by default
......................................................................
southbridge/intel/bd82x6x/Kconfig: Do not include any IFD by default
Since only a handful of boards have descriptor blobs in the tree, it makes no
sense to have `HAVE_IFD_BIN` enabled by default then disabled on each mainboard.
This patch flips the default value of said variable, rendering all current
overrides unnecessary. The few boards which have an IFD in the blobs repo use
`select HAVE_IFD_BIN` to enable adding the IFD by default.
Since `HAVE_ME_BIN` depends on `HAVE_IFD_BIN`, the former has been removed
alongside the latter, and has been added to the boards with a ME blob as
`select HAVE_ME_BIN`.
Both `HAVE_IFD_BIN` and `HAVE_ME_BIN` have been removed from autoport as well.
Change-Id: I330c4886f8bea4b1a8ecad6505a0e5cc381654d1
Signed-off-by: Angel Pons <th3fanbus at gmail.com>
Reviewed-on: https://review.coreboot.org/27218
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Felix Held <felix-coreboot at felixheld.de>
---
M src/mainboard/apple/macbookair4_2/Kconfig
M src/mainboard/asrock/b75pro3-m/Kconfig
M src/mainboard/asus/maximus_iv_gene-z/Kconfig
M src/mainboard/asus/p8h61-m_lx/Kconfig
M src/mainboard/asus/p8h61-m_pro/Kconfig
M src/mainboard/compulab/intense_pc/Kconfig
M src/mainboard/gigabyte/ga-b75m-d3h/Kconfig
M src/mainboard/gigabyte/ga-b75m-d3v/Kconfig
M src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig
M src/mainboard/google/butterfly/Kconfig
M src/mainboard/google/link/Kconfig
M src/mainboard/google/parrot/Kconfig
M src/mainboard/google/stout/Kconfig
M src/mainboard/hp/2570p/Kconfig
M src/mainboard/hp/2760p/Kconfig
M src/mainboard/hp/8460p/Kconfig
M src/mainboard/hp/8470p/Kconfig
M src/mainboard/hp/8770w/Kconfig
M src/mainboard/hp/compaq_8200_elite_sff/Kconfig
M src/mainboard/hp/folio_9470m/Kconfig
M src/mainboard/hp/revolve_810_g1/Kconfig
M src/mainboard/intel/dcp847ske/Kconfig
M src/mainboard/intel/emeraldlake2/Kconfig
M src/mainboard/kontron/ktqm77/Kconfig
M src/mainboard/lenovo/l520/Kconfig
M src/mainboard/lenovo/s230u/Kconfig
M src/mainboard/lenovo/t420/Kconfig
M src/mainboard/lenovo/t420s/Kconfig
M src/mainboard/lenovo/t430/Kconfig
M src/mainboard/lenovo/t430s/Kconfig
M src/mainboard/lenovo/t520/Kconfig
M src/mainboard/lenovo/t530/Kconfig
M src/mainboard/lenovo/x131e/Kconfig
M src/mainboard/lenovo/x1_carbon_gen1/Kconfig
M src/mainboard/lenovo/x220/Kconfig
M src/mainboard/lenovo/x230/Kconfig
M src/mainboard/roda/rv11/Kconfig
M src/mainboard/samsung/lumpy/Kconfig
M src/mainboard/samsung/stumpy/Kconfig
M src/mainboard/sapphire/pureplatinumh61/Kconfig
M src/southbridge/intel/bd82x6x/Kconfig
M util/autoport/sandybridge.go
42 files changed, 14 insertions(+), 262 deletions(-)
Approvals:
build bot (Jenkins): Verified
Felix Held: Looks good to me, approved
diff --git a/src/mainboard/apple/macbookair4_2/Kconfig b/src/mainboard/apple/macbookair4_2/Kconfig
index 347cba2..7253e87 100644
--- a/src/mainboard/apple/macbookair4_2/Kconfig
+++ b/src/mainboard/apple/macbookair4_2/Kconfig
@@ -14,14 +14,6 @@
select SOUTHBRIDGE_INTEL_BD82X6X
select SYSTEM_TYPE_LAPTOP
-config HAVE_IFD_BIN
- bool
- default n
-
-config HAVE_ME_BIN
- bool
- default n
-
config MAINBOARD_DIR
string
default apple/macbookair4_2
diff --git a/src/mainboard/asrock/b75pro3-m/Kconfig b/src/mainboard/asrock/b75pro3-m/Kconfig
index 20ee9a7..af2bd10 100644
--- a/src/mainboard/asrock/b75pro3-m/Kconfig
+++ b/src/mainboard/asrock/b75pro3-m/Kconfig
@@ -30,14 +30,6 @@
select MAINBOARD_HAS_LIBGFXINIT
select DRIVERS_ASMEDIA_ASPM_BLACKLIST
-config HAVE_IFD_BIN
- bool
- default n
-
-config HAVE_ME_BIN
- bool
- default n
-
config MAINBOARD_DIR
string
default asrock/b75pro3-m
diff --git a/src/mainboard/asus/maximus_iv_gene-z/Kconfig b/src/mainboard/asus/maximus_iv_gene-z/Kconfig
index eacf92e..13fad2d 100644
--- a/src/mainboard/asus/maximus_iv_gene-z/Kconfig
+++ b/src/mainboard/asus/maximus_iv_gene-z/Kconfig
@@ -32,10 +32,6 @@
select SUPERIO_NUVOTON_NCT6776
select USE_NATIVE_RAMINIT
-config HAVE_IFD_BIN
- bool
- default n
-
config MAINBOARD_DIR
string
default asus/maximus_iv_gene-z
diff --git a/src/mainboard/asus/p8h61-m_lx/Kconfig b/src/mainboard/asus/p8h61-m_lx/Kconfig
index e3712f1..0960803 100644
--- a/src/mainboard/asus/p8h61-m_lx/Kconfig
+++ b/src/mainboard/asus/p8h61-m_lx/Kconfig
@@ -36,10 +36,6 @@
select SUPERIO_NUVOTON_NCT6776_COM_A
select USE_NATIVE_RAMINIT
-config HAVE_IFD_BIN
- bool
- default n
-
config MAINBOARD_DIR
string
default asus/p8h61-m_lx
diff --git a/src/mainboard/asus/p8h61-m_pro/Kconfig b/src/mainboard/asus/p8h61-m_pro/Kconfig
index cd01b0f..8fcc650 100644
--- a/src/mainboard/asus/p8h61-m_pro/Kconfig
+++ b/src/mainboard/asus/p8h61-m_pro/Kconfig
@@ -32,10 +32,6 @@
select HAVE_CMOS_DEFAULT
select DRIVERS_ASMEDIA_ASPM_BLACKLIST
-config HAVE_IFD_BIN
- bool
- default n
-
config MAINBOARD_DIR
string
default asus/p8h61-m_pro
diff --git a/src/mainboard/compulab/intense_pc/Kconfig b/src/mainboard/compulab/intense_pc/Kconfig
index 557b8ff..fccfb86 100644
--- a/src/mainboard/compulab/intense_pc/Kconfig
+++ b/src/mainboard/compulab/intense_pc/Kconfig
@@ -16,18 +16,6 @@
select USE_NATIVE_RAMINIT
select SUPERIO_SMSC_SIO1007
-config HAVE_IFD_BIN
- bool
- default n
-
-config HAVE_ME_BIN
- bool
- default n
-
-config HAVE_GBE_BIN
- bool
- default n
-
config MAINBOARD_DIR
string
default compulab/intense_pc
diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig b/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig
index 580a9ad..7ec9fe9 100644
--- a/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig
+++ b/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig
@@ -47,14 +47,6 @@
string
default "pci8086,0162.rom"
-config HAVE_IFD_BIN
- bool
- default n
-
-config HAVE_ME_BIN
- bool
- default n
-
config IFD_BIOS_SECTION
string
default "0x00600000:0x007fffff"
diff --git a/src/mainboard/gigabyte/ga-b75m-d3v/Kconfig b/src/mainboard/gigabyte/ga-b75m-d3v/Kconfig
index b8694f5..12b1844 100644
--- a/src/mainboard/gigabyte/ga-b75m-d3v/Kconfig
+++ b/src/mainboard/gigabyte/ga-b75m-d3v/Kconfig
@@ -46,14 +46,6 @@
string
default "pci8086,0102.rom"
-config HAVE_IFD_BIN
- bool
- default n
-
-config HAVE_ME_BIN
- bool
- default n
-
config IFD_BIOS_SECTION
string
default "0x00600000:0x007fffff"
diff --git a/src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig b/src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig
index 406d1ab..a4595f5 100644
--- a/src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig
+++ b/src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig
@@ -33,14 +33,6 @@
select HAVE_OPTION_TABLE
select HAVE_CMOS_DEFAULT
-config HAVE_IFD_BIN
- bool
- default n
-
-config HAVE_ME_BIN
- bool
- default n
-
config MAINBOARD_DIR
string
default "gigabyte/ga-h61m-s2pv"
diff --git a/src/mainboard/google/butterfly/Kconfig b/src/mainboard/google/butterfly/Kconfig
index 8323d7f..7eca2e1 100644
--- a/src/mainboard/google/butterfly/Kconfig
+++ b/src/mainboard/google/butterfly/Kconfig
@@ -17,6 +17,8 @@
select MAINBOARD_HAS_TPM1
select INTEL_INT15
select SERIRQ_CONTINUOUS_MODE # Workaround for EC/KBC IRQ1.
+ select HAVE_IFD_BIN
+ select HAVE_ME_BIN
config VBOOT
select VBOOT_VBNV_CMOS
diff --git a/src/mainboard/google/link/Kconfig b/src/mainboard/google/link/Kconfig
index b7f0c77..18071cf 100644
--- a/src/mainboard/google/link/Kconfig
+++ b/src/mainboard/google/link/Kconfig
@@ -18,6 +18,8 @@
select MAINBOARD_HAS_NATIVE_VGA_INIT
select HAVE_LINEAR_FRAMEBUFFER if MAINBOARD_DO_NATIVE_VGA_INIT
select MAINBOARD_HAS_LIBGFXINIT
+ select HAVE_IFD_BIN
+ select HAVE_ME_BIN
config VBOOT
select EC_GOOGLE_CHROMEEC_SWITCHES
diff --git a/src/mainboard/google/parrot/Kconfig b/src/mainboard/google/parrot/Kconfig
index 50f28e7..ebab7f4 100644
--- a/src/mainboard/google/parrot/Kconfig
+++ b/src/mainboard/google/parrot/Kconfig
@@ -15,6 +15,8 @@
select MAINBOARD_HAS_LPC_TPM
select MAINBOARD_HAS_TPM1
select INTEL_INT15
+ select HAVE_IFD_BIN
+ select HAVE_ME_BIN
# Workaround for EC/KBC IRQ1.
select SERIRQ_CONTINUOUS_MODE
diff --git a/src/mainboard/google/stout/Kconfig b/src/mainboard/google/stout/Kconfig
index ebec5a5..bc96000 100644
--- a/src/mainboard/google/stout/Kconfig
+++ b/src/mainboard/google/stout/Kconfig
@@ -17,6 +17,8 @@
select MAINBOARD_HAS_TPM1
select INTEL_INT15
select SANDYBRIDGE_IVYBRIDGE_LVDS
+ select HAVE_IFD_BIN
+ select HAVE_ME_BIN
config VBOOT
select VBOOT_VBNV_CMOS
diff --git a/src/mainboard/hp/2570p/Kconfig b/src/mainboard/hp/2570p/Kconfig
index dc9588b..8cda10c 100644
--- a/src/mainboard/hp/2570p/Kconfig
+++ b/src/mainboard/hp/2570p/Kconfig
@@ -34,14 +34,6 @@
select HAVE_OPTION_TABLE
select HAVE_CMOS_DEFAULT
-config HAVE_IFD_BIN
- bool
- default n
-
-config HAVE_ME_BIN
- bool
- default n
-
config MAINBOARD_DIR
string
default hp/2570p
diff --git a/src/mainboard/hp/2760p/Kconfig b/src/mainboard/hp/2760p/Kconfig
index 7adf209..3c7c55c 100644
--- a/src/mainboard/hp/2760p/Kconfig
+++ b/src/mainboard/hp/2760p/Kconfig
@@ -34,14 +34,6 @@
select HAVE_OPTION_TABLE
select HAVE_CMOS_DEFAULT
-config HAVE_IFD_BIN
- bool
- default n
-
-config HAVE_ME_BIN
- bool
- default n
-
config MAINBOARD_DIR
string
default hp/2760p
diff --git a/src/mainboard/hp/8460p/Kconfig b/src/mainboard/hp/8460p/Kconfig
index 1486659..56f90b2 100644
--- a/src/mainboard/hp/8460p/Kconfig
+++ b/src/mainboard/hp/8460p/Kconfig
@@ -37,14 +37,6 @@
select HAVE_OPTION_TABLE
select HAVE_CMOS_DEFAULT
-config HAVE_IFD_BIN
- bool
- default n
-
-config HAVE_ME_BIN
- bool
- default n
-
config MAINBOARD_DIR
string
default hp/8460p
diff --git a/src/mainboard/hp/8470p/Kconfig b/src/mainboard/hp/8470p/Kconfig
index 2157867..54ebf14 100644
--- a/src/mainboard/hp/8470p/Kconfig
+++ b/src/mainboard/hp/8470p/Kconfig
@@ -35,14 +35,6 @@
select HAVE_OPTION_TABLE
select HAVE_CMOS_DEFAULT
-config HAVE_IFD_BIN
- bool
- default n
-
-config HAVE_ME_BIN
- bool
- default n
-
config MAINBOARD_DIR
string
default hp/8470p
diff --git a/src/mainboard/hp/8770w/Kconfig b/src/mainboard/hp/8770w/Kconfig
index c650309..4ba13ff 100644
--- a/src/mainboard/hp/8770w/Kconfig
+++ b/src/mainboard/hp/8770w/Kconfig
@@ -33,14 +33,6 @@
select HAVE_OPTION_TABLE
select HAVE_CMOS_DEFAULT
-config HAVE_IFD_BIN
- bool
- default n
-
-config HAVE_ME_BIN
- bool
- default n
-
config MAINBOARD_DIR
string
default hp/8770w
diff --git a/src/mainboard/hp/compaq_8200_elite_sff/Kconfig b/src/mainboard/hp/compaq_8200_elite_sff/Kconfig
index d347306..5960f55 100644
--- a/src/mainboard/hp/compaq_8200_elite_sff/Kconfig
+++ b/src/mainboard/hp/compaq_8200_elite_sff/Kconfig
@@ -19,14 +19,6 @@
select MAINBOARD_HAS_LIBGFXINIT
select INTEL_GMA_HAVE_VBT
-config HAVE_IFD_BIN
- bool
- default n
-
-config HAVE_ME_BIN
- bool
- default n
-
config MAINBOARD_DIR
string
default hp/compaq_8200_elite_sff
diff --git a/src/mainboard/hp/folio_9470m/Kconfig b/src/mainboard/hp/folio_9470m/Kconfig
index 188f8d8..c68f1dc 100644
--- a/src/mainboard/hp/folio_9470m/Kconfig
+++ b/src/mainboard/hp/folio_9470m/Kconfig
@@ -21,14 +21,6 @@
select MAINBOARD_HAS_LIBGFXINIT
select GFX_GMA_INTERNAL_IS_LVDS
-config HAVE_IFD_BIN
- bool
- default n
-
-config HAVE_ME_BIN
- bool
- default n
-
config MAINBOARD_DIR
string
default hp/folio_9470m
diff --git a/src/mainboard/hp/revolve_810_g1/Kconfig b/src/mainboard/hp/revolve_810_g1/Kconfig
index 7816da5..c44fcd9 100644
--- a/src/mainboard/hp/revolve_810_g1/Kconfig
+++ b/src/mainboard/hp/revolve_810_g1/Kconfig
@@ -23,14 +23,6 @@
select MAINBOARD_HAS_LIBGFXINIT
select GFX_GMA_INTERNAL_IS_LVDS
-config HAVE_IFD_BIN
- bool
- default n
-
-config HAVE_ME_BIN
- bool
- default n
-
config MAINBOARD_DIR
string
default hp/revolve_810_g1
diff --git a/src/mainboard/intel/dcp847ske/Kconfig b/src/mainboard/intel/dcp847ske/Kconfig
index 1fd3d8c..ae93e9d 100644
--- a/src/mainboard/intel/dcp847ske/Kconfig
+++ b/src/mainboard/intel/dcp847ske/Kconfig
@@ -25,14 +25,6 @@
endmenu
-config HAVE_IFD_BIN
- bool
- default n
-
-config HAVE_ME_BIN
- bool
- default n
-
config MAINBOARD_DIR
string
default intel/dcp847ske
diff --git a/src/mainboard/intel/emeraldlake2/Kconfig b/src/mainboard/intel/emeraldlake2/Kconfig
index 66c8329..13e4f5b 100644
--- a/src/mainboard/intel/emeraldlake2/Kconfig
+++ b/src/mainboard/intel/emeraldlake2/Kconfig
@@ -11,6 +11,8 @@
select HAVE_OPTION_TABLE
select HAVE_ACPI_RESUME
select INTEL_INT15
+ select HAVE_IFD_BIN
+ select HAVE_ME_BIN
#select MAINBOARD_HAS_CHROMEOS
config VBOOT
diff --git a/src/mainboard/kontron/ktqm77/Kconfig b/src/mainboard/kontron/ktqm77/Kconfig
index 17c2803..10da8d1 100644
--- a/src/mainboard/kontron/ktqm77/Kconfig
+++ b/src/mainboard/kontron/ktqm77/Kconfig
@@ -44,18 +44,6 @@
string
default "Kontron"
-config HAVE_IFD_BIN
- bool
- default n
-
-config HAVE_ME_BIN
- bool
- default n
-
-config HAVE_GBE_BIN
- bool
- default n
-
config IFD_BIOS_SECTION
string
default "0x00580000:0x007fffff"
diff --git a/src/mainboard/lenovo/l520/Kconfig b/src/mainboard/lenovo/l520/Kconfig
index 20ed67c..05174c2 100644
--- a/src/mainboard/lenovo/l520/Kconfig
+++ b/src/mainboard/lenovo/l520/Kconfig
@@ -18,14 +18,6 @@
select SYSTEM_TYPE_LAPTOP
select USE_NATIVE_RAMINIT
-config HAVE_IFD_BIN
- bool
- default n
-
-config HAVE_ME_BIN
- bool
- default n
-
config MAINBOARD_DIR
string
default lenovo/l520
diff --git a/src/mainboard/lenovo/s230u/Kconfig b/src/mainboard/lenovo/s230u/Kconfig
index 2c579b0..01bc4b5 100644
--- a/src/mainboard/lenovo/s230u/Kconfig
+++ b/src/mainboard/lenovo/s230u/Kconfig
@@ -20,14 +20,6 @@
select MAINBOARD_HAS_TPM1
select GENERIC_SPD_BIN
-config HAVE_IFD_BIN
- bool
- default n
-
-config HAVE_ME_BIN
- bool
- default n
-
config MAINBOARD_DIR
string
default lenovo/s230u
diff --git a/src/mainboard/lenovo/t420/Kconfig b/src/mainboard/lenovo/t420/Kconfig
index 40fd213..41c0d37 100644
--- a/src/mainboard/lenovo/t420/Kconfig
+++ b/src/mainboard/lenovo/t420/Kconfig
@@ -29,14 +29,6 @@
# Workaround for EC/KBC IRQ1.
select SERIRQ_CONTINUOUS_MODE
-config HAVE_IFD_BIN
- bool
- default n
-
-config HAVE_ME_BIN
- bool
- default n
-
config MAINBOARD_DIR
string
default lenovo/t420
diff --git a/src/mainboard/lenovo/t420s/Kconfig b/src/mainboard/lenovo/t420s/Kconfig
index ae50975..8eb241a 100644
--- a/src/mainboard/lenovo/t420s/Kconfig
+++ b/src/mainboard/lenovo/t420s/Kconfig
@@ -25,14 +25,6 @@
# Workaround for EC/KBC IRQ1.
select SERIRQ_CONTINUOUS_MODE
-config HAVE_IFD_BIN
- bool
- default n
-
-config HAVE_ME_BIN
- bool
- default n
-
config MAINBOARD_DIR
string
default lenovo/t420s
diff --git a/src/mainboard/lenovo/t430/Kconfig b/src/mainboard/lenovo/t430/Kconfig
index f119def..242412f 100644
--- a/src/mainboard/lenovo/t430/Kconfig
+++ b/src/mainboard/lenovo/t430/Kconfig
@@ -27,14 +27,6 @@
select GFX_GMA_INTERNAL_IS_LVDS
select INTEL_GMA_HAVE_VBT
-config HAVE_IFD_BIN
- bool
- default n
-
-config HAVE_ME_BIN
- bool
- default n
-
config MAINBOARD_DIR
string
default lenovo/t430
diff --git a/src/mainboard/lenovo/t430s/Kconfig b/src/mainboard/lenovo/t430s/Kconfig
index a938dcc..728dd5c 100644
--- a/src/mainboard/lenovo/t430s/Kconfig
+++ b/src/mainboard/lenovo/t430s/Kconfig
@@ -27,14 +27,6 @@
# Workaround for EC/KBC IRQ1.
select SERIRQ_CONTINUOUS_MODE
-config HAVE_IFD_BIN
- bool
- default n
-
-config HAVE_ME_BIN
- bool
- default n
-
config MAINBOARD_DIR
string
default lenovo/t430s
diff --git a/src/mainboard/lenovo/t520/Kconfig b/src/mainboard/lenovo/t520/Kconfig
index 824f299..85dedb3 100644
--- a/src/mainboard/lenovo/t520/Kconfig
+++ b/src/mainboard/lenovo/t520/Kconfig
@@ -25,14 +25,6 @@
if BOARD_LENOVO_BASEBOARD_T520
-config HAVE_IFD_BIN
- bool
- default n
-
-config HAVE_ME_BIN
- bool
- default n
-
config VARIANT_DIR
string
default "t520" if BOARD_LENOVO_T520
diff --git a/src/mainboard/lenovo/t530/Kconfig b/src/mainboard/lenovo/t530/Kconfig
index 0bbf941..d107504 100644
--- a/src/mainboard/lenovo/t530/Kconfig
+++ b/src/mainboard/lenovo/t530/Kconfig
@@ -28,14 +28,6 @@
if BOARD_LENOVO_BASEBOARD_T530
-config HAVE_IFD_BIN
- bool
- default n
-
-config HAVE_ME_BIN
- bool
- default n
-
config VARIANT_DIR
string
default "t530" if BOARD_LENOVO_T530
diff --git a/src/mainboard/lenovo/x131e/Kconfig b/src/mainboard/lenovo/x131e/Kconfig
index 3cf3078..d88f313 100644
--- a/src/mainboard/lenovo/x131e/Kconfig
+++ b/src/mainboard/lenovo/x131e/Kconfig
@@ -23,10 +23,6 @@
select GFX_GMA_INTERNAL_IS_LVDS
select SERIRQ_CONTINUOUS_MODE
-config HAVE_IFD_BIN
- bool
- default n
-
config MAINBOARD_DIR
string
default lenovo/x131e
diff --git a/src/mainboard/lenovo/x1_carbon_gen1/Kconfig b/src/mainboard/lenovo/x1_carbon_gen1/Kconfig
index d33018e..9ffd410 100644
--- a/src/mainboard/lenovo/x1_carbon_gen1/Kconfig
+++ b/src/mainboard/lenovo/x1_carbon_gen1/Kconfig
@@ -27,14 +27,6 @@
# Workaround for EC/KBC IRQ1.
select SERIRQ_CONTINUOUS_MODE
-config HAVE_IFD_BIN
- bool
- default n
-
-config HAVE_ME_BIN
- bool
- default n
-
config MAINBOARD_DIR
string
default lenovo/x1_carbon_gen1
diff --git a/src/mainboard/lenovo/x220/Kconfig b/src/mainboard/lenovo/x220/Kconfig
index 54d3648..a710c84 100644
--- a/src/mainboard/lenovo/x220/Kconfig
+++ b/src/mainboard/lenovo/x220/Kconfig
@@ -26,14 +26,6 @@
# Workaround for EC/KBC IRQ1.
select SERIRQ_CONTINUOUS_MODE
-config HAVE_IFD_BIN
- bool
- default n
-
-config HAVE_ME_BIN
- bool
- default n
-
config MAINBOARD_DIR
string
default lenovo/x220
diff --git a/src/mainboard/lenovo/x230/Kconfig b/src/mainboard/lenovo/x230/Kconfig
index 29c0e7b..2725dcd 100644
--- a/src/mainboard/lenovo/x230/Kconfig
+++ b/src/mainboard/lenovo/x230/Kconfig
@@ -27,14 +27,6 @@
# Workaround for EC/KBC IRQ1.
select SERIRQ_CONTINUOUS_MODE
-config HAVE_IFD_BIN
- bool
- default n
-
-config HAVE_ME_BIN
- bool
- default n
-
config MAINBOARD_DIR
string
default lenovo/x230
diff --git a/src/mainboard/roda/rv11/Kconfig b/src/mainboard/roda/rv11/Kconfig
index 4f8a438..4485aee 100644
--- a/src/mainboard/roda/rv11/Kconfig
+++ b/src/mainboard/roda/rv11/Kconfig
@@ -43,18 +43,6 @@
string
default "Roda"
-config HAVE_IFD_BIN
- bool
- default n
-
-config HAVE_ME_BIN
- bool
- default n
-
-config HAVE_GBE_BIN
- bool
- default n
-
config IFD_BIOS_SECTION
string
default "0x00d80000:0x00ffffff"
diff --git a/src/mainboard/samsung/lumpy/Kconfig b/src/mainboard/samsung/lumpy/Kconfig
index 80f5dab..9cb0e5f 100644
--- a/src/mainboard/samsung/lumpy/Kconfig
+++ b/src/mainboard/samsung/lumpy/Kconfig
@@ -15,6 +15,8 @@
select NORTHBRIDGE_INTEL_SANDYBRIDGE
select SOUTHBRIDGE_INTEL_BD82X6X
select SUPERIO_SMSC_MEC1308
+ select HAVE_IFD_BIN
+ select HAVE_ME_BIN
# LPC47N207 selected for external LPC card
# not on board, should be made selectable.
select SUPERIO_SMSC_LPC47N207
diff --git a/src/mainboard/samsung/stumpy/Kconfig b/src/mainboard/samsung/stumpy/Kconfig
index b15b4b6..f0ac4f7 100644
--- a/src/mainboard/samsung/stumpy/Kconfig
+++ b/src/mainboard/samsung/stumpy/Kconfig
@@ -14,6 +14,8 @@
select NORTHBRIDGE_INTEL_SANDYBRIDGE
select SOUTHBRIDGE_INTEL_BD82X6X
select SUPERIO_ITE_IT8772F
+ select HAVE_IFD_BIN
+ select HAVE_ME_BIN
# LPC47N207 selected for external LPC card
# not on board, should be made selectable.
select SUPERIO_SMSC_LPC47N207
diff --git a/src/mainboard/sapphire/pureplatinumh61/Kconfig b/src/mainboard/sapphire/pureplatinumh61/Kconfig
index 42cda6e..a07617e 100644
--- a/src/mainboard/sapphire/pureplatinumh61/Kconfig
+++ b/src/mainboard/sapphire/pureplatinumh61/Kconfig
@@ -17,10 +17,6 @@
select INTEL_INT15
select NO_UART_ON_SUPERIO
-config HAVE_IFD_BIN
- bool
- default n
-
config MAINBOARD_DIR
string
default sapphire/pureplatinumh61
diff --git a/src/southbridge/intel/bd82x6x/Kconfig b/src/southbridge/intel/bd82x6x/Kconfig
index 9a70bf2..3033e20 100644
--- a/src/southbridge/intel/bd82x6x/Kconfig
+++ b/src/southbridge/intel/bd82x6x/Kconfig
@@ -66,9 +66,6 @@
hex
default 0x80
-config HAVE_IFD_BIN
- def_bool y
-
config BUILD_WITH_FAKE_IFD
def_bool !HAVE_IFD_BIN
diff --git a/util/autoport/sandybridge.go b/util/autoport/sandybridge.go
index e54e6a6..cf2b859 100644
--- a/util/autoport/sandybridge.go
+++ b/util/autoport/sandybridge.go
@@ -119,9 +119,6 @@
KconfigBool["HAVE_ACPI_TABLES"] = true
KconfigBool["HAVE_ACPI_RESUME"] = true
- KconfigBool["HAVE_IFD_BIN"] = false
- KconfigBool["HAVE_ME_BIN"] = false
-
KconfigInt["MAX_CPUS"] = 8
DSDTIncludes = append(DSDTIncludes, DSDTInclude{
--
To view, visit https://review.coreboot.org/27218
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I330c4886f8bea4b1a8ecad6505a0e5cc381654d1
Gerrit-Change-Number: 27218
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180805/09e9da49/attachment.html>
More information about the coreboot-gerrit
mailing list