[coreboot-gerrit] Change in coreboot[master]: google/grunt: Override BayHub EMMC driving strength
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Fri Aug 3 20:02:53 CEST 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27816 )
Change subject: google/grunt: Override BayHub EMMC driving strength
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/27816/3/src/mainboard/google/kahlee/variants/baseboard/mainboard.c
File src/mainboard/google/kahlee/variants/baseboard/mainboard.c:
https://review.coreboot.org/#/c/27816/3/src/mainboard/google/kahlee/variants/baseboard/mainboard.c@59
PS3, Line 59: bh720_pcr_data | (BH720_PCR_CLK_DRV_MAX << 4) | (bh720_pcr_data_CMD_DRV_MAX << 1));
line over 80 characters
https://review.coreboot.org/#/c/27816/3/src/mainboard/google/kahlee/variants/baseboard/mainboard.c@59
PS3, Line 59: bh720_pcr_data | (BH720_PCR_CLK_DRV_MAX << 4) | (bh720_pcr_data_CMD_DRV_MAX << 1));
code indent should use tabs where possible
--
To view, visit https://review.coreboot.org/27816
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3db38ff12c566c258895c6643008a0472ca528bb
Gerrit-Change-Number: 27816
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Chiu <Kevin.Chiu at quantatw.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 03 Aug 2018 18:02:53 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180803/5afec2f6/attachment.html>
More information about the coreboot-gerrit
mailing list