[coreboot-gerrit] Change in coreboot[master]: google/grunt: Override BayHub EMMC driving strength

Martin Roth (Code Review) gerrit at coreboot.org
Fri Aug 3 16:27:27 CEST 2018


Martin Roth has posted comments on this change. ( https://review.coreboot.org/27816 )

Change subject: google/grunt: Override BayHub EMMC driving strength
......................................................................


Patch Set 2:

(1 comment)

Did this help for you?  When I was testing, it didn't seem to make any difference.

https://review.coreboot.org/#/c/27816/2/src/mainboard/google/kahlee/variants/baseboard/mainboard.c
File src/mainboard/google/kahlee/variants/baseboard/mainboard.c:

https://review.coreboot.org/#/c/27816/2/src/mainboard/google/kahlee/variants/baseboard/mainboard.c@43
PS2, Line 43: u32 SDBAR;
            : 	u32 BH720_PCR_DATA;
lowercase?



-- 
To view, visit https://review.coreboot.org/27816
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3db38ff12c566c258895c6643008a0472ca528bb
Gerrit-Change-Number: 27816
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chiu <Kevin.Chiu at quantatw.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 03 Aug 2018 14:27:27 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180803/39c68f74/attachment.html>


More information about the coreboot-gerrit mailing list