[coreboot-gerrit] Change in coreboot[master]: mb/pcengines/apu2: change GPIO setting

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Fri Aug 3 12:43:35 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27665 )

Change subject: mb/pcengines/apu2: change GPIO setting
......................................................................


Patch Set 8:

(1 comment)

https://review.coreboot.org/#/c/27665/8/src/mainboard/pcengines/apu2/romstage.c
File src/mainboard/pcengines/apu2/romstage.c:

https://review.coreboot.org/#/c/27665/8/src/mainboard/pcengines/apu2/romstage.c@116
PS8, Line 116: 	if (IS_ENABLED(CONFIG_BOARD_PCENGINES_APU5)) {
braces {} are not necessary for single statement blocks



-- 
To view, visit https://review.coreboot.org/27665
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf4a60acabe65cd7f9985bb3af8bd577764d4196
Gerrit-Change-Number: 27665
Gerrit-PatchSet: 8
Gerrit-Owner: Michał Żygowski <michal.zygowski at 3mdeb.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski at 3mdeb.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Piotr Król <piotr.krol at 3mdeb.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: kamran javed <kamrangulhaji315a at gmail.com>
Gerrit-CC: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Comment-Date: Fri, 03 Aug 2018 10:43:35 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180803/53b6a917/attachment.html>


More information about the coreboot-gerrit mailing list