[coreboot-gerrit] Change in coreboot[master]: util/bincfg: don't use sym_table shared variable
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Thu Aug 2 22:20:28 CEST 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27810 )
Change subject: util/bincfg: don't use sym_table shared variable
......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/27810/1/util/bincfg/bincfg.h
File util/bincfg/bincfg.h:
https://review.coreboot.org/#/c/27810/1/util/bincfg/bincfg.h@30
PS1, Line 30: typedef struct field* field_t;
"foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/27810/1/util/bincfg/bincfg.h@31
PS1, Line 31: typedef struct field** field_ptr_t;
"foo** bar" should be "foo **bar"
https://review.coreboot.org/#/c/27810/1/util/bincfg/bincfg.h@44
PS1, Line 44: static void yyerror(FILE* fp, field_ptr_t, char const *);
"foo* bar" should be "foo *bar"
--
To view, visit https://review.coreboot.org/27810
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I652a8da75498f871a53eb7509f6145c4842e3373
Gerrit-Change-Number: 27810
Gerrit-PatchSet: 1
Gerrit-Owner: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 02 Aug 2018 20:20:28 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180802/68018aac/attachment.html>
More information about the coreboot-gerrit
mailing list