[coreboot-gerrit] Change in coreboot[master]: cpu/x86/lapic/apic_timer.c: Compile the same code for all stages

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27801 )

Change subject: cpu/x86/lapic/apic_timer.c: Compile the same code for all stages
......................................................................


Patch Set 2: Code-Review+1

(3 comments)

https://review.coreboot.org/#/c/27801/2//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/27801/2//COMMIT_MSG@9
PS2, Line 9:  
line is too long, break here


https://review.coreboot.org/#/c/27801/1/src/cpu/x86/lapic/apic_timer.c
File src/cpu/x86/lapic/apic_timer.c:

https://review.coreboot.org/#/c/27801/1/src/cpu/x86/lapic/apic_timer.c@156
PS1, Line 156: 
don't we need `car_get_var_ptr()` here?

... ok, you were faster :-P


https://review.coreboot.org/#/c/27801/2/src/cpu/x86/lapic/apic_timer.c
File src/cpu/x86/lapic/apic_timer.c:

https://review.coreboot.org/#/c/27801/2/src/cpu/x86/lapic/apic_timer.c@150
PS2, Line 150: static inline struct monotonic_counter *get_monotonic_context(void)
Having a single-line function for a single invocation seems overkill.



-- 
To view, visit https://review.coreboot.org/27801
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08fd1795508f76abdab1618585366bf9d06482ff
Gerrit-Change-Number: 27801
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 02 Aug 2018 12:00:22 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180802/c4a1972e/attachment.html>