[coreboot-gerrit] Change in coreboot[master]: Documentation/Makefile.sphinx: Be cautious when running `rm -rf`

Tristan Corrick (Code Review) gerrit at coreboot.org
Wed Aug 1 14:06:54 CEST 2018


Tristan Corrick has uploaded this change for review. ( https://review.coreboot.org/27775


Change subject: Documentation/Makefile.sphinx: Be cautious when running `rm -rf`
......................................................................

Documentation/Makefile.sphinx: Be cautious when running `rm -rf`

If BUILDDIR were an empty string, running `make clean` would result in
running `rm -rf /*`. Omitting the trailing /* prevents this.

With a valid BUILDDIR, the behaviour of `make clean` changes slightly in
that BUILDDIR itself is removed. However, this is probably more in line
with what one would expect from `make clean`.

Change-Id: I51b52bb6e7fe73a07fed6291a4f1cc253f2bf319
Signed-off-by: Tristan Corrick <tristan at corrick.kiwi>
---
M Documentation/Makefile.sphinx
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/27775/1

diff --git a/Documentation/Makefile.sphinx b/Documentation/Makefile.sphinx
index 0ecebbe..2357f18 100644
--- a/Documentation/Makefile.sphinx
+++ b/Documentation/Makefile.sphinx
@@ -46,7 +46,7 @@
 
 .PHONY: clean
 clean:
-	rm -rf $(BUILDDIR)/*
+	rm -rf $(BUILDDIR)
 
 .PHONY: html
 html:

-- 
To view, visit https://review.coreboot.org/27775
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I51b52bb6e7fe73a07fed6291a4f1cc253f2bf319
Gerrit-Change-Number: 27775
Gerrit-PatchSet: 1
Gerrit-Owner: Tristan Corrick <tristan at corrick.kiwi>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180801/fc8110c6/attachment.html>


More information about the coreboot-gerrit mailing list