[coreboot-gerrit] Change in coreboot[master]: drivers/spi: Read Winbond's flash protection bits

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25082 )

Change subject: drivers/spi: Read Winbond's flash protection bits
......................................................................


Patch Set 13:

(9 comments)

https://review.coreboot.org/#/c/25082/13/src/drivers/spi/winbond.c
File src/drivers/spi/winbond.c:

https://review.coreboot.org/#/c/25082/13/src/drivers/spi/winbond.c@52
PS13, Line 52: 	uint8_t	*const	prot;
"foo	*const	bar" should be "foo	*const bar"


https://review.coreboot.org/#/c/25082/13/src/drivers/spi/winbond.c@132
PS13, Line 132: 		.prot			= (u8[6]){
space required before the open brace '{'


https://review.coreboot.org/#/c/25082/13/src/drivers/spi/winbond.c@150
PS13, Line 150: 		.prot			= (u8[7]){
space required before the open brace '{'


https://review.coreboot.org/#/c/25082/13/src/drivers/spi/winbond.c@169
PS13, Line 169: 		.prot			= (u8[7]){
space required before the open brace '{'


https://review.coreboot.org/#/c/25082/13/src/drivers/spi/winbond.c@188
PS13, Line 188: 		.prot			= (u8[7]){
space required before the open brace '{'


https://review.coreboot.org/#/c/25082/13/src/drivers/spi/winbond.c@207
PS13, Line 207: 		.prot			= (u8[7]){
space required before the open brace '{'


https://review.coreboot.org/#/c/25082/13/src/drivers/spi/winbond.c@226
PS13, Line 226: 		.prot			= (u8[7]){
space required before the open brace '{'


https://review.coreboot.org/#/c/25082/13/src/drivers/spi/winbond.c@245
PS13, Line 245: 		.prot			= (u8[7]){
space required before the open brace '{'


https://review.coreboot.org/#/c/25082/13/src/drivers/spi/winbond.c@264
PS13, Line 264: 		.prot			= (u8[10]){
space required before the open brace '{'



-- 
To view, visit https://review.coreboot.org/25082
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I933a8abdc28174ec32acf323c102d606b58c1ea5
Gerrit-Change-Number: 25082
Gerrit-PatchSet: 13
Gerrit-Owner: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: David Hendricks <david.hendricks at gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan at google.com>
Gerrit-Comment-Date: Wed, 01 Aug 2018 09:12:42 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180801/bc88491e/attachment.html>