[coreboot-gerrit] Change in coreboot[master]: google/cyan: Mark GpioInt() resources as PullDefault
Matt DeVillier (Code Review)
gerrit at coreboot.org
Wed Aug 1 00:23:30 CEST 2018
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/27760
Change subject: google/cyan: Mark GpioInt() resources as PullDefault
......................................................................
google/cyan: Mark GpioInt() resources as PullDefault
Adapted from chromium commit 3750e09
[Strago: mark GpioInt() resources as PullDefault]
coreboot considers GPIO resources first-class citizens and initializes
all pads according to their intended use, with necessary pull settings
applied. Therefore let's use PullDefault as pull qualifier in AML,
letting the kernel know that it shoudl not attempt to alter pull settings
when using GPIOs.
TEST=Built and booted on celes, cyan, and egdar; built for other cyan devices.
Original-Change-Id: Iff58a324e73a7eeac9b38df05a095fcfe7acd31b
Original-Signed-off-by: Dmitry Torokhov <dtor at chromium.org>
Original-Reviewed-on: https://chromium-review.googlesource.com/898259
Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
Change-Id: I0c69e77c58b8ceca71bc0c99e16d10c3e539f783
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
M src/mainboard/google/cyan/acpi/codec_maxim.asl
M src/mainboard/google/cyan/acpi/codec_realtek.asl
M src/mainboard/google/cyan/acpi/mainboard.asl
M src/mainboard/google/cyan/acpi/superio.asl
M src/mainboard/google/cyan/acpi/touchscreen_elan.asl
M src/mainboard/google/cyan/acpi/touchscreen_melfas.asl
M src/mainboard/google/cyan/acpi/touchscreen_synaptics.asl
M src/mainboard/google/cyan/acpi/trackpad_atmel.asl
M src/mainboard/google/cyan/acpi/trackpad_elan.asl
9 files changed, 12 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/27760/1
diff --git a/src/mainboard/google/cyan/acpi/codec_maxim.asl b/src/mainboard/google/cyan/acpi/codec_maxim.asl
index 9abc91e..81bec16 100644
--- a/src/mainboard/google/cyan/acpi/codec_maxim.asl
+++ b/src/mainboard/google/cyan/acpi/codec_maxim.asl
@@ -47,7 +47,7 @@
"\\_SB.PCI0.I2C2", /* ResourceSource: I2C bus controller name */
)
- GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,
+ GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullDefault,,
"\\_SB.GPSE") { BOARD_JACK_MAXIM_GPIO_INDEX }
} )
Return (SBUF)
@@ -91,7 +91,7 @@
"\\_SB.PCI0.I2C2", /* ResourceSource: I2C bus controller name */
)
- GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,
+ GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullDefault,,
"\\_SB.GPSW") { BOARD_JACK_TI_GPIO_INDEX }
} )
@@ -111,7 +111,7 @@
Name (GBUF, ResourceTemplate ()
{
/* Jack Detect (index 0) */
- GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,
+ GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullDefault,,
"\\_SB.GPSE") { BOARD_JACK_MAXIM_GPIO_INDEX }
})
}
diff --git a/src/mainboard/google/cyan/acpi/codec_realtek.asl b/src/mainboard/google/cyan/acpi/codec_realtek.asl
index d3fa84e..4a1d48d 100644
--- a/src/mainboard/google/cyan/acpi/codec_realtek.asl
+++ b/src/mainboard/google/cyan/acpi/codec_realtek.asl
@@ -39,7 +39,7 @@
)
/* Jack Detect (index 0) */
- GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,
+ GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullDefault,,
"\\_SB.GPSW") { JACK_DETECT_GPIO_INDEX }
} )
Return (SBUF)
@@ -57,7 +57,7 @@
Name (GBUF, ResourceTemplate ()
{
/* Jack Detect (index 0) */
- GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,
+ GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullDefault,,
"\\_SB.GPSW") { JACK_DETECT_GPIO_INDEX }
})
}
diff --git a/src/mainboard/google/cyan/acpi/mainboard.asl b/src/mainboard/google/cyan/acpi/mainboard.asl
index 9f27ac9..af0dc75 100644
--- a/src/mainboard/google/cyan/acpi/mainboard.asl
+++ b/src/mainboard/google/cyan/acpi/mainboard.asl
@@ -23,7 +23,7 @@
{
Name (RBUF, ResourceTemplate ()
{
- GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,
+ GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullDefault,,
"\\_SB.GPNC") { BOARD_SCI_GPIO_INDEX }
})
Return (RBUF)
diff --git a/src/mainboard/google/cyan/acpi/superio.asl b/src/mainboard/google/cyan/acpi/superio.asl
index ca973d0..b3961c0 100644
--- a/src/mainboard/google/cyan/acpi/superio.asl
+++ b/src/mainboard/google/cyan/acpi/superio.asl
@@ -23,7 +23,7 @@
#define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */
/* Override default IRQ settings */
-#define SIO_EC_PS2K_IRQ GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,\
+#define SIO_EC_PS2K_IRQ GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullDefault,,\
"\\_SB.GPNC") { BOARD_I8042_GPIO_INDEX }
/* ACPI code for EC SuperIO functions */
diff --git a/src/mainboard/google/cyan/acpi/touchscreen_elan.asl b/src/mainboard/google/cyan/acpi/touchscreen_elan.asl
index 7e3c7ae..cd67a0e 100644
--- a/src/mainboard/google/cyan/acpi/touchscreen_elan.asl
+++ b/src/mainboard/google/cyan/acpi/touchscreen_elan.asl
@@ -35,7 +35,7 @@
AddressingMode7Bit, /* AddressingMode */
"\\_SB.PCI0.I2C1", /* ResourceSource */
)
- GpioInt (Level, ActiveLow, ExclusiveAndWake, PullNone,,
+ GpioInt (Level, ActiveLow, ExclusiveAndWake, PullDefault,,
"\\_SB.GPNC") { BOARD_TOUCH_GPIO_INDEX }
} )
diff --git a/src/mainboard/google/cyan/acpi/touchscreen_melfas.asl b/src/mainboard/google/cyan/acpi/touchscreen_melfas.asl
index f54f886..905b7b8 100644
--- a/src/mainboard/google/cyan/acpi/touchscreen_melfas.asl
+++ b/src/mainboard/google/cyan/acpi/touchscreen_melfas.asl
@@ -35,7 +35,7 @@
AddressingMode7Bit, /* AddressingMode */
"\\_SB.I2C1", /* ResourceSource */
)
- GpioInt (Level, ActiveLow, ExclusiveAndWake, PullNone,,
+ GpioInt (Level, ActiveLow, ExclusiveAndWake, PullDefault,,
"\\_SB.GPNC") { BOARD_TOUCH_GPIO_INDEX }
})
Return (BUF0)
diff --git a/src/mainboard/google/cyan/acpi/touchscreen_synaptics.asl b/src/mainboard/google/cyan/acpi/touchscreen_synaptics.asl
index f0db3a3..1b10848 100644
--- a/src/mainboard/google/cyan/acpi/touchscreen_synaptics.asl
+++ b/src/mainboard/google/cyan/acpi/touchscreen_synaptics.asl
@@ -78,7 +78,7 @@
AddressingMode7Bit, /* AddressingMode */
"\\_SB.PCI0.I2C1", /* ResourceSource */
)
- GpioInt (Level, ActiveLow, ExclusiveAndWake, PullNone,,
+ GpioInt (Level, ActiveLow, ExclusiveAndWake, PullDefault,,
"\\_SB.GPNC") { BOARD_TOUCH_GPIO_INDEX }
})
Return (BUF0)
diff --git a/src/mainboard/google/cyan/acpi/trackpad_atmel.asl b/src/mainboard/google/cyan/acpi/trackpad_atmel.asl
index 96f3185..9e63d12 100644
--- a/src/mainboard/google/cyan/acpi/trackpad_atmel.asl
+++ b/src/mainboard/google/cyan/acpi/trackpad_atmel.asl
@@ -33,7 +33,7 @@
AddressingMode7Bit, // AddressingMode
"\\_SB.PCI0.I2C6", // ResourceSource
)
- GpioInt (Level, ActiveLow, ExclusiveAndWake, PullNone,,
+ GpioInt (Level, ActiveLow, ExclusiveAndWake, PullDefault,,
"\\_SB.GPNC") { BOARD_TRACKPAD_GPIO_INDEX }
})
diff --git a/src/mainboard/google/cyan/acpi/trackpad_elan.asl b/src/mainboard/google/cyan/acpi/trackpad_elan.asl
index f89e1bc..4a80c19 100644
--- a/src/mainboard/google/cyan/acpi/trackpad_elan.asl
+++ b/src/mainboard/google/cyan/acpi/trackpad_elan.asl
@@ -32,7 +32,7 @@
AddressingMode7Bit, /* AddressingMode */
"\\_SB.PCI0.I2C6", /* ResourceSource */
)
- GpioInt (Level, ActiveLow, ExclusiveAndWake, PullNone,,
+ GpioInt (Level, ActiveLow, ExclusiveAndWake, PullDefault,,
"\\_SB.GPNC") { BOARD_TRACKPAD_GPIO_INDEX }
})
--
To view, visit https://review.coreboot.org/27760
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0c69e77c58b8ceca71bc0c99e16d10c3e539f783
Gerrit-Change-Number: 27760
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180731/ced6a963/attachment-0001.html>
More information about the coreboot-gerrit
mailing list