[coreboot-gerrit] Change in coreboot[master]: mb/google/kahlee: Update i2c timings

Martin Roth (Code Review) gerrit at coreboot.org
Mon Apr 30 21:25:09 CEST 2018


Martin Roth has uploaded this change for review. ( https://review.coreboot.org/25942


Change subject: mb/google/kahlee: Update i2c timings
......................................................................

mb/google/kahlee: Update i2c timings

Change the I2c timings to the latest measurements.

BUG=b:72442912
TEST=Boot grunt

Change-Id: Ib961ec7c2b0a677d9cacdb7d91e5c78173d42017
Signed-off-by: Martin Roth <martinroth at google.com>
---
M src/mainboard/google/kahlee/variants/grunt/devicetree.cb
1 file changed, 7 insertions(+), 7 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/25942/1

diff --git a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb
index cfc3198..65e9ae8 100644
--- a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb
+++ b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb
@@ -24,30 +24,30 @@
 	# Enable I2C0 for audio, USB3 hub at 400kHz
 	register "i2c[0]" = "{
 		.speed = I2C_SPEED_FAST,
-		.rise_time_ns = 95,
-		.fall_time_ns = 3,
+		.rise_time_ns = 300,
+		.fall_time_ns = 34,
 	}"
 
 	# Enable I2C1 for H1 at 400kHz
 	register "i2c[1]" = "{
 		.early_init = 1,
 		.speed = I2C_SPEED_FAST,
-		.rise_time_ns = 84,
+		.rise_time_ns = 140,
 		.fall_time_ns = 4,
 	}"
 
 	# Enable I2C2 for trackpad, pen at 400kHz
 	register "i2c[2]" = "{
 		.speed = I2C_SPEED_FAST,
-		.rise_time_ns = 117,
-		.fall_time_ns = 113,
+		.rise_time_ns = 320,
+		.fall_time_ns = 34,
 	}"
 
 	# Enable I2C3 for touchscreen at 400kHz
 	register "i2c[3]" = "{
 		.speed = I2C_SPEED_FAST,
-		.rise_time_ns = 82,
-		.fall_time_ns = 67,
+		.rise_time_ns = 320,
+		.fall_time_ns = 34,
 	}"
 
 	device cpu_cluster 0 on

-- 
To view, visit https://review.coreboot.org/25942
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib961ec7c2b0a677d9cacdb7d91e5c78173d42017
Gerrit-Change-Number: 25942
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180430/1f26422c/attachment.html>


More information about the coreboot-gerrit mailing list