[coreboot-gerrit] Change in coreboot[master]: lenovo: Add various vbt.bin

Nico Huber (Code Review) gerrit at coreboot.org
Mon Apr 30 14:57:17 CEST 2018


Nico Huber has posted comments on this change. ( https://review.coreboot.org/25926 )

Change subject: lenovo: Add various vbt.bin
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

+2 for all but T400

https://review.coreboot.org/#/c/25926/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/25926/1//COMMIT_MSG@10
PS1, Line 10: coreboot's blob free graphics init.
No line break or start a new paragraph.


https://review.coreboot.org/#/c/25926/1/src/mainboard/lenovo/t400/vbt.bin
File src/mainboard/lenovo/t400/vbt.bin:

PS1: 
Lenovo shipped two different BIOS versions for the X200 (one for
LED backlight, one for CCFL). Same might be true for the T400.
If that's the case, we should either add runtime detection /
patching of VBT or a Kconfig choice for the variant.



-- 
To view, visit https://review.coreboot.org/25926
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15573ddd37ee9738df1f7178f967131687a50f48
Gerrit-Change-Number: 25926
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Mon, 30 Apr 2018 12:57:17 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180430/dee250a6/attachment.html>


More information about the coreboot-gerrit mailing list