[coreboot-gerrit] Change in coreboot[master]: buildgcc: Add missing '\'

Patrick Georgi (Code Review) gerrit at coreboot.org
Sat Apr 28 09:17:02 CEST 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/25901 )

Change subject: buildgcc: Add missing '\'
......................................................................

buildgcc: Add missing '\'

That caused the CFLAGS, CXXFLAGS, and '|| touch .failed' to not be taken
into account when building binutils.

Change-Id: I94521eb73cefdc5ed01fbf10122966a54cc28166
Signed-off-by: Vivia Nikolaidou <vivia.nikolaidou at puri.sm>
Reviewed-on: https://review.coreboot.org/25901
Reviewed-by: Youness Alaoui <snifikino at gmail.com>
Reviewed-by: Matt DeVillier <matt.devillier at gmail.com>
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
---
M util/crossgcc/buildgcc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Matt DeVillier: Looks good to me, approved
  Youness Alaoui: Looks good to me, approved



diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index 743937a..edcea7a 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -681,7 +681,7 @@
 		--target=${TARGETARCH} --enable-targets=${TARGETARCH}${ADDITIONALTARGET} \
 		--disable-werror --disable-nls --enable-lto --enable-gold \
 		--enable-interwork --enable-multilib \
-		--enable-plugins --enable-multilibs
+		--enable-plugins --enable-multilibs \
 		CFLAGS="$HOSTCFLAGS" \
 		CXXFLAGS="$HOSTCFLAGS" \
 		|| touch .failed

-- 
To view, visit https://review.coreboot.org/25901
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I94521eb73cefdc5ed01fbf10122966a54cc28166
Gerrit-Change-Number: 25901
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward #1001977
Gerrit-Reviewer: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180428/341e368a/attachment.html>


More information about the coreboot-gerrit mailing list