[coreboot-gerrit] Change in coreboot[master]: mb/google/octopus: Fix crossystem wpsw_cur error

Hannah Williams (Code Review) gerrit at coreboot.org
Fri Apr 27 08:43:43 CEST 2018


Hannah Williams has uploaded this change for review. ( https://review.coreboot.org/25892


Change subject: mb/google/octopus: Fix crossystem wpsw_cur error
......................................................................

mb/google/octopus: Fix crossystem wpsw_cur error

With only one entry for Write Protect gpio in the OIPG package, the sysfs
entry /sys/devices/platform/chromeos_acpi/GPIO.x  is created as "GPIO"
instead of "GPIO.x".This was causing crossytem to return error for wpsw_cur.

BUG=b:78009842

Change-Id: Ica60f342420d95d09a45580f2f940443c03601de
Signed-off-by: Hannah Williams <hannah.williams at intel.com>
---
M src/mainboard/google/octopus/variants/baseboard/gpio.c
M src/soc/intel/apollolake/include/soc/gpio_glk.h
2 files changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/25892/1

diff --git a/src/mainboard/google/octopus/variants/baseboard/gpio.c b/src/mainboard/google/octopus/variants/baseboard/gpio.c
index 8863bbb..1f2e728 100644
--- a/src/mainboard/google/octopus/variants/baseboard/gpio.c
+++ b/src/mainboard/google/octopus/variants/baseboard/gpio.c
@@ -300,6 +300,7 @@
 }
 
 static const struct cros_gpio cros_gpios[] = {
+	CROS_GPIO_REC_AL(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME),
 	CROS_GPIO_WP_AH(PAD_SCC(GPIO_PCH_WP), GPIO_COMM_SCC_NAME),
 };
 
diff --git a/src/soc/intel/apollolake/include/soc/gpio_glk.h b/src/soc/intel/apollolake/include/soc/gpio_glk.h
index 7145a28..63bee3b 100644
--- a/src/soc/intel/apollolake/include/soc/gpio_glk.h
+++ b/src/soc/intel/apollolake/include/soc/gpio_glk.h
@@ -321,6 +321,7 @@
 #define PAD_SCC(pad)			(pad - SCC_OFFSET)
 
 /* Linux names of the GPIO devices. */
+#define CROS_GPIO_DEVICE_NAME		"INT3453"
 #define GPIO_COMM_NW_NAME		"INT3453:00"
 #define GPIO_COMM_N_NAME		"INT3453:01"
 #define GPIO_COMM_AUDIO_NAME		"INT3453:02"

-- 
To view, visit https://review.coreboot.org/25892
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica60f342420d95d09a45580f2f940443c03601de
Gerrit-Change-Number: 25892
Gerrit-PatchSet: 1
Gerrit-Owner: Hannah Williams <hannah.williams at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180427/ea8df239/attachment.html>


More information about the coreboot-gerrit mailing list