[coreboot-gerrit] Change in coreboot[master]: mb/google/grunt: Add grunt touchpad wake GPE to devicestree
Daniel Kurtz (Code Review)
gerrit at coreboot.org
Wed Apr 25 19:24:00 CEST 2018
Hello Daniel Kurtz,
I'd like you to do a code review. Please visit
https://review.coreboot.org/25827
to review the following change.
Change subject: mb/google/grunt: Add grunt touchpad wake GPE to devicestree
......................................................................
mb/google/grunt: Add grunt touchpad wake GPE to devicestree
The grunt touchpad interrupt can be used as a wake source. For grunt,
the touchpad interrupt uses GPIO5 which corresponds to GEVENT7.
BUG=b:77602771
TEST=In OS: # cat /proc/acpi/wakeup
=> D015 S3 *enabled i2c:i2c-ELAN0000:00
TEST=powerd_dbus_suspend, touching touchpad (> 1 sec) wakes from S3.
Change-Id: I510642108a1257f6601f18c77cf3107573427f39
Signed-off-by: Daniel Kurtz <djkurtz at chromium.org>
---
M src/mainboard/google/kahlee/variants/grunt/devicetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/25827/1
diff --git a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb
index f55a424..cfc3198 100644
--- a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb
+++ b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb
@@ -125,7 +125,7 @@
register "hid" = ""ELAN0000""
register "desc" = ""ELAN Touchpad""
register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_5)"
- # TODO(teravest): Add wake
+ register "wake" = "7"
device i2c 15 on end
end
end
--
To view, visit https://review.coreboot.org/25827
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I510642108a1257f6601f18c77cf3107573427f39
Gerrit-Change-Number: 25827
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180425/3431c69d/attachment-0001.html>
More information about the coreboot-gerrit
mailing list