[coreboot-gerrit] Change in coreboot[master]: vx900: Drop some unused defines

Patrick Georgi (Code Review) gerrit at coreboot.org
Wed Apr 25 13:43:08 CEST 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/25800 )

Change subject: vx900: Drop some unused defines
......................................................................

vx900: Drop some unused defines

These are redundant -- the actual APIC Ids and addresses are in the
devicetree.

Change-Id: I895563dd574a8f4631866ceec91a20cbc3b158e4
Signed-off-by: Lubomir Rintel <lkundrak at v3.sk>
Reviewed-on: https://review.coreboot.org/25800
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Martin Roth <martinroth at google.com>
---
M src/northbridge/via/vx900/vx900.h
1 file changed, 0 insertions(+), 6 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved



diff --git a/src/northbridge/via/vx900/vx900.h b/src/northbridge/via/vx900/vx900.h
index 216f637..fe756f9 100644
--- a/src/northbridge/via/vx900/vx900.h
+++ b/src/northbridge/via/vx900/vx900.h
@@ -18,12 +18,6 @@
 
 #define VX900_ACPI_IO_BASE		0x0400
 
-#define VX900_NB_IOAPIC_ID		0x2
-#define VX900_NB_IOAPIC_BASE		0xfecc000
-
-#define VX900_SB_IOAPIC_ID		0x1
-#define VX900_SB_IOAPIC_BASE		0xfec0000
-
 #define SMBUS_IO_BASE	0x500
 
 #define VX900_MMCONFIG_MBAR		0xbc

-- 
To view, visit https://review.coreboot.org/25800
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I895563dd574a8f4631866ceec91a20cbc3b158e4
Gerrit-Change-Number: 25800
Gerrit-PatchSet: 2
Gerrit-Owner: Lubomir Rintel <lkundrak at v3.sk>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180425/3dcfe386/attachment.html>


More information about the coreboot-gerrit mailing list