[coreboot-gerrit] Change in coreboot[master]: asrock/b75pro3-m: use the ASPM blacklist driver

Iru Cai (Code Review) gerrit at coreboot.org
Wed Apr 25 09:51:35 CEST 2018


Iru Cai has uploaded this change for review. ( https://review.coreboot.org/25819


Change subject: asrock/b75pro3-m: use the ASPM blacklist driver
......................................................................

asrock/b75pro3-m: use the ASPM blacklist driver

After commit 2188f57a (src/device: Update LTR configuration scheme)
coreboot will hang when reading resources on the ASMedia SATA
controller, although there is already an ASPM config override. So use
the ASPM blacklist driver instead of setting the ASPM override in the
devicetree.

Change-Id: I807d9bd4deef8c1528dff96c7646240ef75e1953
Signed-off-by: Iru Cai <mytbk920423 at gmail.com>
---
M src/mainboard/asrock/b75pro3-m/Kconfig
M src/mainboard/asrock/b75pro3-m/devicetree.cb
2 files changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/25819/1

diff --git a/src/mainboard/asrock/b75pro3-m/Kconfig b/src/mainboard/asrock/b75pro3-m/Kconfig
index 010de97..20ee9a7 100644
--- a/src/mainboard/asrock/b75pro3-m/Kconfig
+++ b/src/mainboard/asrock/b75pro3-m/Kconfig
@@ -28,6 +28,7 @@
 	select SOUTHBRIDGE_INTEL_C216
 	select USE_NATIVE_RAMINIT
 	select MAINBOARD_HAS_LIBGFXINIT
+	select DRIVERS_ASMEDIA_ASPM_BLACKLIST
 
 config HAVE_IFD_BIN
 	bool
diff --git a/src/mainboard/asrock/b75pro3-m/devicetree.cb b/src/mainboard/asrock/b75pro3-m/devicetree.cb
index 70b65aa..def3d1d 100644
--- a/src/mainboard/asrock/b75pro3-m/devicetree.cb
+++ b/src/mainboard/asrock/b75pro3-m/devicetree.cb
@@ -106,7 +106,6 @@
 			device pci 1c.4 on # PCIe Port #5, ASMedia ASM1062 SATA Controller
 				subsystemid 0x1849 0x1e18
 			end
-			register "pcie_aspm_f4" = "0x80" # Disable ASPM for ASMedia SATA controller
 			device pci 1c.5 on # PCIe Port #6, Realtek PCIe GbE Controller
 				subsystemid 0x1849 0x1e1a
 			end

-- 
To view, visit https://review.coreboot.org/25819
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I807d9bd4deef8c1528dff96c7646240ef75e1953
Gerrit-Change-Number: 25819
Gerrit-PatchSet: 1
Gerrit-Owner: Iru Cai <mytbk920423 at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180425/e598755d/attachment.html>


More information about the coreboot-gerrit mailing list