[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge: Static constify smi_sources

Daniel Kurtz (Code Review) gerrit at coreboot.org
Wed Apr 25 02:33:45 CEST 2018


Hello Daniel Kurtz,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/25814

to review the following change.


Change subject: soc/amd/stoneyridge: Static constify smi_sources
......................................................................

soc/amd/stoneyridge: Static constify smi_sources

smi_sources is a file local array of constants.

Change-Id: I431f181449a591ccaf8395f01a84c8e006a29b52
Signed-off-by: Daniel Kurtz <djkurtz at chromium.org>
---
M src/soc/amd/stoneyridge/smihandler.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/25814/1

diff --git a/src/soc/amd/stoneyridge/smihandler.c b/src/soc/amd/stoneyridge/smihandler.c
index 2830d18..6063789 100644
--- a/src/soc/amd/stoneyridge/smihandler.c
+++ b/src/soc/amd/stoneyridge/smihandler.c
@@ -186,7 +186,7 @@
  * Table of functions supported in the SMI handler.  Note that SMI source setup
  * in southbridge.c is unrelated to this list.
  */
-struct smi_sources_t smi_sources[] = {
+static const struct smi_sources_t smi_sources[] = {
 	{ .type = SMITYPE_SMI_CMD_PORT, .handler = sb_apmc_smi_handler },
 	{ .type = SMITYPE_SLP_TYP, .handler = sb_slp_typ_handler},
 };

-- 
To view, visit https://review.coreboot.org/25814
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I431f181449a591ccaf8395f01a84c8e006a29b52
Gerrit-Change-Number: 25814
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180425/c86335ce/attachment-0001.html>


More information about the coreboot-gerrit mailing list