[coreboot-gerrit] Change in coreboot[master]: soc/intel/common: Implement EFI_MP_SERVICES_PPI structure APIs

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/25634 )

Change subject: soc/intel/common: Implement EFI_MP_SERVICES_PPI structure APIs
......................................................................


Patch Set 10:

IMHO I think the FSP-M (ram init) integration was okay from our point of view. Putting everything into FSP-S and FSP-T means for us on long term that we won't have more intel open source code. Instead we are getting more and more restricted code blocks. We really really don't want to work with a BLOB we can't debug, understand and where it takes up few weeks to do a coreboot mainboard support.

We are an open source and not a closed source project... I know Intel needs to support coreboot customers. But please don't try to put more and more stuff into the FSP. Instead try to open source parts of the FSP. Also if you write interface discussions are needed and we want to see an interface design draft.

So be part of our community! Also maybe it would be better if more people would join us on IRC and actively discuss things. At least you, Naresh and Lijian Zhao.


-- 
To view, visit https://review.coreboot.org/25634
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie844e3f15f759ea09a8f3fd24825ee740151c956
Gerrit-Change-Number: 25634
Gerrit-PatchSet: 10
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Idwer Vollering <vidwer at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin at chromium.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Tue, 24 Apr 2018 15:08:31 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180424/8b40c1d4/attachment.html>