[coreboot-gerrit] Change in coreboot[master]: [WIP] soc/intel/apollolake: Use bootblock common stage

Bora Guvendik (Code Review) gerrit at coreboot.org
Tue Apr 24 02:24:53 CEST 2018


Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/25802 )

Change subject: [WIP] soc/intel/apollolake: Use bootblock common stage
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/25802/3/src/soc/intel/apollolake/bootblock/pch.c
File src/soc/intel/apollolake/bootblock/pch.c:

https://review.coreboot.org/#/c/25802/3/src/soc/intel/apollolake/bootblock/pch.c@89
PS3, Line 89: 	if (IS_ENABLED(CONFIG_SOC_UART_DEBUG))
            : 		pch_uart_init();
this should be removed



-- 
To view, visit https://review.coreboot.org/25802
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I319453c902632f26eec63ab9c1e9bb6956b466fb
Gerrit-Change-Number: 25802
Gerrit-PatchSet: 3
Gerrit-Owner: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 24 Apr 2018 00:24:53 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180424/8583fd6c/attachment.html>


More information about the coreboot-gerrit mailing list