[coreboot-gerrit] Change in coreboot[master]: siemens/mc_apl1: Provide baseboard and variant concepts

[Mario Scheithauer (Code Review)]

Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/25785 )

Change subject: siemens/mc_apl1: Provide baseboard and variant concepts
......................................................................


Patch Set 2:

(8 comments)

https://review.coreboot.org/#/c/25785/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/25785/1//COMMIT_MSG@9
PS1, Line 9: Apollo Lak
> Add a spce: Apollo Lake
Done


https://review.coreboot.org/#/c/25785/1//COMMIT_MSG@10
PS1, Line 10: reference
> reference
Done


https://review.coreboot.org/#/c/25785/1//COMMIT_MSG@11
PS1, Line 11:  
> remove this comma
Done


https://review.coreboot.org/#/c/25785/1//COMMIT_MSG@17
PS1, Line 17:  
> can be removed
Done


https://review.coreboot.org/#/c/25785/1//COMMIT_MSG@18
PS1, Line 18:  
> can be removed
Done


https://review.coreboot.org/#/c/25785/1//COMMIT_MSG@25
PS1, Line 25: be added under
> be added
Done


https://review.coreboot.org/#/c/25785/1/src/mainboard/siemens/mc_apl1/Kconfig
File src/mainboard/siemens/mc_apl1/Kconfig:

https://review.coreboot.org/#/c/25785/1/src/mainboard/siemens/mc_apl1/Kconfig@7
PS1, Line 7: select USE_SIEMENS_HWILI
> I would better activate the (final) board specific switches in the variants Kconfig rather than here […]
There is now also a Kconfig file in the subfolder and the board-specific stuff is moved there .


https://review.coreboot.org/#/c/25785/1/src/mainboard/siemens/mc_apl1/variants/baseboard/gpio.c
File src/mainboard/siemens/mc_apl1/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/25785/1/src/mainboard/siemens/mc_apl1/variants/baseboard/gpio.c@17
PS1, Line 17:  <commonlib/helpers.h>
> Make this include the last one in the list.
Done



-- 
To view, visit https://review.coreboot.org/25785
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3c1f45daee3b9690a448b82edbeec552ee05973
Gerrit-Change-Number: 25785
Gerrit-PatchSet: 2
Gerrit-Owner: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 23 Apr 2018 12:09:53 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180423/2fa223a1/attachment.html>