[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/atlas: Enable trackpad

[Caveh Jalali (Code Review)]

Hello caveh jalali,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/25759

to review the following change.


Change subject: mb/google/poppy/atlas: Enable trackpad
......................................................................

mb/google/poppy/atlas: Enable trackpad

This enables the i2c trackpad on atlas.

BUG=b:75454415
TEST=able to move pointer using trackpad

Change-Id: If4a82aa605ec68fd38e52c13406eaf803f9e86cc
Signed-off-by: Caveh Jalali <caveh at chromium.org>
---
M src/mainboard/google/poppy/variants/atlas/devicetree.cb
1 file changed, 11 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/25759/1

diff --git a/src/mainboard/google/poppy/variants/atlas/devicetree.cb b/src/mainboard/google/poppy/variants/atlas/devicetree.cb
index 3d31c40..4444549 100644
--- a/src/mainboard/google/poppy/variants/atlas/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/atlas/devicetree.cb
@@ -247,7 +247,17 @@
 		device pci 14.2 on  end # Thermal Subsystem
 		device pci 15.0 on  end # I2C #0 - Touchscreen
 		device pci 15.1 off end # I2C #1
-		device pci 15.2 on  end # I2C #2 - Trackpad
+		device pci 15.2 on
+			chip drivers/i2c/generic
+				register "hid" = ""ELAN0000""
+				register "desc" = ""ELAN Touchpad""
+				register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_A19_IRQ)"
+				# TODO(caveh): fix wake source
+				#register "wake" = "GPE0_DWx_19" not possible?
+				register "probed" = "1" # may not be present
+				device i2c 0x15 on end
+			end
+		end # I2C #2 - Trackpad
 		device pci 15.3 on  end # I2C #3 - Camera
 		device pci 16.0 on  end # Management Engine Interface 1
 		device pci 16.1 off end # Management Engine Interface 2

-- 
To view, visit https://review.coreboot.org/25759
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If4a82aa605ec68fd38e52c13406eaf803f9e86cc
Gerrit-Change-Number: 25759
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali <caveh at google.com>
Gerrit-Reviewer: caveh jalali <caveh at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180421/4d9f660f/attachment-0001.html>