[coreboot-gerrit] Change in coreboot[master]: mb/google/bip: Add GPIO configuration settings

[Justin TerAvest (Code Review)]

Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/25741 )

Change subject: mb/google/bip: Add GPIO configuration settings
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/25741/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/25741/1//COMMIT_MSG@9
PS1, Line 9: copy of yorp settings
> Did you compare yorp and bip GPIOs to see if there are any differences at all? If not, it might make […]
There are some differences.
For example,

Bip uses GPIO66 for LTE OFF
WLAN moved from GPIO149 to 178.
I have a hacked together diff I'll provide in the bug.



-- 
To view, visit https://review.coreboot.org/25741
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc205f576691427d78c9159dfdbced87e41a0517
Gerrit-Change-Number: 25741
Gerrit-PatchSet: 1
Gerrit-Owner: Shamile Khan <shamile.khan at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Justin TerAvest <teravest at chromium.org>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 19 Apr 2018 20:42:54 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180419/6c6ca8ca/attachment.html>