[coreboot-gerrit] Change in coreboot[master]: device/oprom/yabel: Modify vbe-buffer index in vbe.c

Hal Tsai (Code Review) gerrit at coreboot.org
Thu Apr 19 08:30:06 CEST 2018


Hal Tsai has uploaded this change for review. ( https://review.coreboot.org/25736


Change subject: device/oprom/yabel: Modify vbe-buffer index in vbe.c
......................................................................

device/oprom/yabel: Modify vbe-buffer index in vbe.c

There's a issue about {VbeSignature to "VBE2" to indicate VBE 2.0+ request},
these indexes are counted mistake.

Change-Id: I8ec85df60076162518aa55a94fa7b66c0c2391ab
Signed-off-by: Hal Tsai <hal_tsai at compal.corp-partner.google.com>
---
M src/device/oprom/yabel/vbe.c
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/25736/1

diff --git a/src/device/oprom/yabel/vbe.c b/src/device/oprom/yabel/vbe.c
index 876df23..4995a02 100644
--- a/src/device/oprom/yabel/vbe.c
+++ b/src/device/oprom/yabel/vbe.c
@@ -75,9 +75,9 @@
 	memset(vbe_info_buffer, 0, 512);
 	//set VbeSignature to "VBE2" to indicate VBE 2.0+ request
 	vbe_info_buffer[0] = 'V';
-	vbe_info_buffer[0] = 'B';
-	vbe_info_buffer[0] = 'E';
-	vbe_info_buffer[0] = '2';
+	vbe_info_buffer[1] = 'B';
+	vbe_info_buffer[2] = 'E';
+	vbe_info_buffer[3] = '2';
 	// ES:DI store pointer to buffer in virtual mem see vbe_info_buffer above...
 	M.x86.R_EDI = 0x0;
 	M.x86.R_ES = VBE_SEGMENT;

-- 
To view, visit https://review.coreboot.org/25736
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8ec85df60076162518aa55a94fa7b66c0c2391ab
Gerrit-Change-Number: 25736
Gerrit-PatchSet: 1
Gerrit-Owner: Hal Tsai <hal_tsai at compal.corp-partner.google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180419/6328e75a/attachment.html>


More information about the coreboot-gerrit mailing list