[coreboot-gerrit] Change in coreboot[master]: sb/intel/common/rcba_pirq: Fix clang enum conversion error

Alex James (Code Review) gerrit at coreboot.org
Sat Apr 14 20:53:35 CEST 2018


Alex James has uploaded this change for review. ( https://review.coreboot.org/25677


Change subject: sb/intel/common/rcba_pirq: Fix clang enum conversion error
......................................................................

sb/intel/common/rcba_pirq: Fix clang enum conversion error

This fixes the following clang error:

src/southbridge/intel/common/rcba_pirq.c:30:10: error: implicit conversion
    from enumeration type 'const pci_pin_t' (aka 'const enum pci_pin') to
    different enumeration type 'enum pirq' [-Werror,-Wenum-conversion]
                return pci_pin;
                ~~~~~~ ^~~~~~~

Change-Id: I66cfd6f0ebab750149d1ea1bc7425fc3b17bb253
Signed-off-by: Alex James <theracermaster at gmail.com>
---
M src/southbridge/intel/common/rcba_pirq.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/25677/1

diff --git a/src/southbridge/intel/common/rcba_pirq.c b/src/southbridge/intel/common/rcba_pirq.c
index 44d2f3d..411418a 100644
--- a/src/southbridge/intel/common/rcba_pirq.c
+++ b/src/southbridge/intel/common/rcba_pirq.c
@@ -27,7 +27,7 @@
 
 	if (slot < MIN_SLOT || slot > MAX_SLOT) {
 		/* non-PCH devices use 1:1 mapping. */
-		return pci_pin;
+		return (pirq_t) pci_pin;
 	}
 
 	reg = pirq_dir_route_reg[slot - MIN_SLOT];

-- 
To view, visit https://review.coreboot.org/25677
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I66cfd6f0ebab750149d1ea1bc7425fc3b17bb253
Gerrit-Change-Number: 25677
Gerrit-PatchSet: 1
Gerrit-Owner: Alex James <theracermaster at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180414/4a7ba968/attachment.html>


More information about the coreboot-gerrit mailing list