[coreboot-gerrit] Change in coreboot[master]: nb/intel/sandybridge: support more XMP timings

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/25664 )

Change subject: nb/intel/sandybridge: support more XMP timings
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

https://review.coreboot.org/#/c/25664/1/src/northbridge/intel/sandybridge/raminit_common.c
File src/northbridge/intel/sandybridge/raminit_common.c:

https://review.coreboot.org/#/c/25664/1/src/northbridge/intel/sandybridge/raminit_common.c@2362
PS1, Line 2362: 			/* XMP gives the CMD rate in clock ticks, not ns */
> The value here is offset by 1: 0 for a CMD rate of 1, 1 for a CMD rate of 2. […]
Ah, right


https://review.coreboot.org/#/c/25664/2/src/northbridge/intel/sandybridge/raminit_common.c
File src/northbridge/intel/sandybridge/raminit_common.c:

https://review.coreboot.org/#/c/25664/2/src/northbridge/intel/sandybridge/raminit_common.c@2355
PS2, Line 2355: 		 * TODO: How to detect "1T" DIMMs ?
update the comment ?
"Works only for dual XMP 1T DIMMs"



-- 
To view, visit https://review.coreboot.org/25664
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I634bed764d76345c27f02a2fae5abb2d81b38fd9
Gerrit-Change-Number: 25664
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Elkouby <streetwalkermc at gmail.com>
Gerrit-Reviewer: Dan Elkouby <streetwalkermc at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Sat, 14 Apr 2018 11:07:16 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180414/1c782263/attachment.html>