[coreboot-gerrit] Change in coreboot[master]: mb/asus/p5qpl-am: Add support for ASUS P5QPL-AM

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/25659 )

Change subject: mb/asus/p5qpl-am: Add support for ASUS P5QPL-AM
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/25659/1/src/mainboard/asus/p5qpl-am/devicetree.cb
File src/mainboard/asus/p5qpl-am/devicetree.cb:

https://review.coreboot.org/#/c/25659/1/src/mainboard/asus/p5qpl-am/devicetree.cb@127
PS1, Line 127: # W83115RG-965
> you sure your device has this?
oh btw this the clockgen component. Usually its is a rectangular shaped package that is close to a crystal. It looks like https://en.wikipedia.org/wiki/Clock_generator#/media/File:ICS_952018AF.jpg



-- 
To view, visit https://review.coreboot.org/25659
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I160f9201e812f44ef9842caef851750fb7690c9e
Gerrit-Change-Number: 25659
Gerrit-PatchSet: 1
Gerrit-Owner: AndiR <andir at memeware.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Comment-Date: Fri, 13 Apr 2018 20:05:00 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180413/a478ea97/attachment.html>