[coreboot-gerrit] Change in coreboot[master]: drivers/uart: Allow the 8250IO driver only on x86

Jonathan Neuschäfer (Code Review) gerrit at coreboot.org
Thu Apr 12 12:04:28 CEST 2018


Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/25631


Change subject: drivers/uart: Allow the 8250IO driver only on x86
......................................................................

drivers/uart: Allow the 8250IO driver only on x86

The driver relies on I/O space access functions (inb, etc.), which are
only available on x86.

Rather than explicitly disallowing it on ARM, allow it only on x86.

TEST=Configure for RISC-V, and see that "Serial port on SuperIO" is not
available in the "Generic Drivers" menu anymore.

Change-Id: Ib8e8c402264afeba6dc098683c5464af6edb3ba3
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
---
M src/drivers/uart/Kconfig
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/25631/1

diff --git a/src/drivers/uart/Kconfig b/src/drivers/uart/Kconfig
index 54f591d..3738222 100644
--- a/src/drivers/uart/Kconfig
+++ b/src/drivers/uart/Kconfig
@@ -5,9 +5,9 @@
 
 config DRIVERS_UART_8250IO
 	bool "Serial port on SuperIO"
-	depends on !ARCH_ARM
+	depends on ARCH_X86
 	default n if NO_UART_ON_SUPERIO
-	default y if ARCH_X86
+	default y
 
 config DRIVERS_UART_8250IO_SKIP_INIT
 	def_bool n

-- 
To view, visit https://review.coreboot.org/25631
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib8e8c402264afeba6dc098683c5464af6edb3ba3
Gerrit-Change-Number: 25631
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180412/7056990d/attachment.html>


More information about the coreboot-gerrit mailing list