[coreboot-gerrit] Change in coreboot[master]: drivers/uart/pl011.c Add write support

Marcello Sylvester Bauer (Code Review) gerrit at coreboot.org
Wed Apr 11 17:30:20 CEST 2018


Marcello Sylvester Bauer has posted comments on this change. ( https://review.coreboot.org/25623 )

Change subject: drivers/uart/pl011.c Add write support
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/25623/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/25623/1//COMMIT_MSG@7
PS1, Line 7: drivers/uart/pl011.c Add write support
> pl011:
Done


https://review.coreboot.org/#/c/25623/1/src/drivers/uart/pl011.c
File src/drivers/uart/pl011.c:

https://review.coreboot.org/#/c/25623/1/src/drivers/uart/pl011.c@47
PS1, Line 47: 	while (read32(&regs->fr) & PL011_UARTFR_RXFE)
> braces not neccessary
Done



-- 
To view, visit https://review.coreboot.org/25623
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a33b3cd4b333fb244bc55747014a301021e25e0
Gerrit-Change-Number: 25623
Gerrit-PatchSet: 2
Gerrit-Owner: Marcello Sylvester Bauer
Gerrit-Reviewer: Marcello Sylvester Bauer
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Comment-Date: Wed, 11 Apr 2018 15:30:20 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180411/c34b7854/attachment.html>


More information about the coreboot-gerrit mailing list