[coreboot-gerrit] Change in coreboot[master]: device: Add flag to disable PCIe ASPM

Nico Huber (Code Review) gerrit at coreboot.org
Wed Apr 11 13:51:43 CEST 2018


Nico Huber has uploaded this change for review. ( https://review.coreboot.org/25617


Change subject: device: Add flag to disable PCIe ASPM
......................................................................

device: Add flag to disable PCIe ASPM

For broken devices that spuriously advertise ASPM, make it possible to
decide ASPM activation in the device driver.

Change-Id: I491aa32a3ec954be87a474478609f0f3971d0fdf
Signed-off-by: Nico Huber <nico.huber at secunet.com>
---
M src/device/pciexp_device.c
M src/include/device/device.h
2 files changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/25617/1

diff --git a/src/device/pciexp_device.c b/src/device/pciexp_device.c
index c020159..29d9208 100644
--- a/src/device/pciexp_device.c
+++ b/src/device/pciexp_device.c
@@ -376,6 +376,9 @@
 	u16 lnkctl;
 	u32 devcap;
 
+	if (endp->disable_pcie_aspm)
+		return;
+
 	/* Get endpoint device capabilities for acceptable limits */
 	devcap = pci_read_config32(endp, endp_cap + PCI_EXP_DEVCAP);
 
diff --git a/src/include/device/device.h b/src/include/device/device.h
index 15e477a..3e6ba39 100644
--- a/src/include/device/device.h
+++ b/src/include/device/device.h
@@ -129,6 +129,7 @@
 	unsigned int    enabled : 1;	/* set if we should enable the device */
 	unsigned int  initialized : 1; /* 1 if we have initialized the device */
 	unsigned int    on_mainboard : 1;
+	unsigned int    disable_pcie_aspm : 1;
 	struct pci_irq_info pci_irq_info[4];
 	u8 command;
 

-- 
To view, visit https://review.coreboot.org/25617
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I491aa32a3ec954be87a474478609f0f3971d0fdf
Gerrit-Change-Number: 25617
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180411/2cde9503/attachment.html>


More information about the coreboot-gerrit mailing list