[coreboot-gerrit] Change in coreboot[master]: mb/google/fizz: Add device index for 2nd LAN

[Marco Chen (Code Review)]

Marco Chen has posted comments on this change. ( https://review.coreboot.org/25587 )

Change subject: mb/google/fizz: Add device index for 2nd LAN
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/25587/1/src/mainboard/google/fizz/devicetree.cb
File src/mainboard/google/fizz/devicetree.cb:

https://review.coreboot.org/#/c/25587/1/src/mainboard/google/fizz/devicetree.cb@376
PS1, Line 376: 				register "device_index" = "1"
For multiple LAN interfaces, as I know we should set device_index from 1 to 10. In case of Fizz, we should set these two interfaces's device_index to 1 and 2 so VPDs would be ethernet_mac0 and ethernet_mac1.

Therefore line 354 should have device_index as 1 and here be 2?



-- 
To view, visit https://review.coreboot.org/25587
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic357a3f1435d6d08107520e40872f1003ef2edf3
Gerrit-Change-Number: 25587
Gerrit-PatchSet: 1
Gerrit-Owner: David Wu <david_wu at quantatw.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai at intel.com>
Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai at intel.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Marco Chen <marcochen at google.com>
Gerrit-Comment-Date: Tue, 10 Apr 2018 12:55:03 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180410/25d1e645/attachment.html>