[coreboot-gerrit] Change in coreboot[master]: mb/google/peppy: Fix touchscreen ACPI

Arthur Heymans (Code Review) gerrit at coreboot.org
Sun Apr 8 18:29:17 CEST 2018


Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/25558


Change subject: mb/google/peppy: Fix touchscreen ACPI
......................................................................

mb/google/peppy: Fix touchscreen ACPI

Fix touchscreen on Acer C720p.

The problem was introduced in b5a74d6c "Remove boards google/falco and
google/peppy" and c12e5ae1 "Add/Combine Haswell Chromebooks using
variant board scheme".

Change-Id: Ia9cc7b92e8e61751e85b861a50db2c1735154598
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/mainboard/google/slippy/variants/peppy/include/variant/acpi/mainboard.asl
1 file changed, 4 insertions(+), 8 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/25558/1

diff --git a/src/mainboard/google/slippy/variants/peppy/include/variant/acpi/mainboard.asl b/src/mainboard/google/slippy/variants/peppy/include/variant/acpi/mainboard.asl
index cc3e063..0924bc9 100644
--- a/src/mainboard/google/slippy/variants/peppy/include/variant/acpi/mainboard.asl
+++ b/src/mainboard/google/slippy/variants/peppy/include/variant/acpi/mainboard.asl
@@ -116,14 +116,10 @@
 		Name (GPIO, 25)
 		Name (_CRS, ResourceTemplate()
 		{
-			I2cSerialBus (
-				0x4a,                     // SlaveAddress
-				ControllerInitiated,      // SlaveMode
-				400000,                   // ConnectionSpeed
-				AddressingMode7Bit,       // AddressingMode
-				"\\_SB.PCI0.I2C1"        // ResourceSource
-			)
-
+			VendorShort (ADDR)
+			{
+				BOARD_TOUCHSCREEN_I2C_ADDR
+			}
 			// GPIO54 (ball L3) is PIRQW: PIRQL_GSI + PIRQL - PIRQW = PIRQW_GSI
 			// 27 + 3 - 14 = 38
 			Interrupt (ResourceConsumer, Edge, ActiveLow) { 38 }

-- 
To view, visit https://review.coreboot.org/25558
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia9cc7b92e8e61751e85b861a50db2c1735154598
Gerrit-Change-Number: 25558
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180408/61059cdd/attachment.html>


More information about the coreboot-gerrit mailing list