[coreboot-gerrit] Change in coreboot[master]: util/scripts/ucode_h_to_bin.sh: Accept microcode in INC format

Piotr Król (Code Review) gerrit at coreboot.org
Fri Apr 6 14:48:13 CEST 2018


Piotr Król has posted comments on this change. ( https://review.coreboot.org/25546 )

Change subject: util/scripts/ucode_h_to_bin.sh: Accept microcode in INC format
......................................................................


Patch Set 1:

(1 comment)

Please add Bay Trail maintainers.

https://review.coreboot.org/#/c/25546/1/src/soc/intel/fsp_baytrail/Kconfig
File src/soc/intel/fsp_baytrail/Kconfig:

https://review.coreboot.org/#/c/25546/1/src/soc/intel/fsp_baytrail/Kconfig@100
PS1, Line 100: 	default "../Vlv2MiscBinariesPkg/Microcode"
Why you changed this line? This is very specific to MinnowBoard Turbot Binary Objects package - I'm not sure we can generalize in that way. Even if can change that we should not do that in one commit.



-- 
To view, visit https://review.coreboot.org/25546
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c716e5ad42e55ab3a3a67de1e9bf10e58855540
Gerrit-Change-Number: 25546
Gerrit-PatchSet: 1
Gerrit-Owner: Lev
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Piotr Król <piotr.krol at 3mdeb.com>
Gerrit-Comment-Date: Fri, 06 Apr 2018 12:48:13 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180406/1b563735/attachment.html>


More information about the coreboot-gerrit mailing list