[coreboot-gerrit] Change in coreboot[master]: ioapic: extend definition name to avoid collision

Martin Roth (Code Review) gerrit at coreboot.org
Fri Apr 6 00:06:25 CEST 2018


Martin Roth has posted comments on this change. ( https://review.coreboot.org/25540 )

Change subject: ioapic: extend definition  name to avoid collision
......................................................................


Patch Set 1: Code-Review+2

(2 comments)

Looks good other than the minor issues in the commit message.

https://review.coreboot.org/#/c/25540/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/25540/1//COMMIT_MSG@7
PS1, Line 7:  
extra space


https://review.coreboot.org/#/c/25540/1//COMMIT_MSG@9
PS1, Line 9: colission
collision



-- 
To view, visit https://review.coreboot.org/25540
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I85b1c544d0f31340a09e18f4b36c1942ea0fa6ef
Gerrit-Change-Number: 25540
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Comment-Date: Thu, 05 Apr 2018 22:06:25 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180405/abb6112c/attachment.html>


More information about the coreboot-gerrit mailing list