[coreboot-gerrit] Change in coreboot[master]: google/gru: Fix pmu1833_volsel handling

Julius Werner (Code Review) gerrit at coreboot.org
Thu Sep 28 01:44:32 CEST 2017


Hello Lin Huang, David Schneider, Philip Chen, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/21727

to look at the new patch set (#2).

Change subject: google/gru: Fix pmu1833_volsel handling
......................................................................

google/gru: Fix pmu1833_volsel handling

RK3399 has a pin that can decide whether GPIO port 1 is driven with 1.8V
or 3.0V. We thought this mechanism was disabled by default, but it turns
out it wasn't. We want to use that pin as an output GPIO on Scarlet so
we need to reconfigure the respective SoC controls before we do that. It
seems that we also need to explicitly pinmux the pin away from that
special function (to normal GPIO) or weird things happen on some boards.

BUG=b:66534913
TEST=Sprinkled several long udelays, poked test points with a
multi-meter on Scarlet.

Change-Id: Ia02cbb4f3b2f14b0d958b84adcddb0c5f4259efa
Signed-off-by: Julius Werner <jwerner at chromium.org>
---
M src/mainboard/google/gru/bootblock.c
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/21727/2
-- 
To view, visit https://review.coreboot.org/21727
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia02cbb4f3b2f14b0d958b84adcddb0c5f4259efa
Gerrit-Change-Number: 21727
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: David Schneider <dnschneid at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Lin Huang <hl at rock-chips.com>
Gerrit-Reviewer: Philip Chen <philipchen at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170927/22f58475/attachment.html>


More information about the coreboot-gerrit mailing list