[coreboot-gerrit] Change in coreboot[master]: soc/amd/common: Add framework for missing AGESA callouts

[Martin Roth (Code Review)]

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/21707


Change subject: soc/amd/common: Add framework for missing AGESA callouts
......................................................................

soc/amd/common: Add framework for missing AGESA callouts

These are required callout functions that currently are not implemented.
agesa_LateRunApTask does not seem to be called, but the others are.

BUG=b:66690176
TEST=Build Kahlee.  Tested in next commit.

Change-Id: Iee5f9c4847a5309a25045fca8c73be4f811c281a
Signed-off-by: Martin Roth <martinroth at google.com>
---
M src/soc/amd/common/BiosCallOuts.h
M src/soc/amd/common/def_callouts.c
2 files changed, 50 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/21707/1

diff --git a/src/soc/amd/common/BiosCallOuts.h b/src/soc/amd/common/BiosCallOuts.h
index 4456466..9f6f8a7 100644
--- a/src/soc/amd/common/BiosCallOuts.h
+++ b/src/soc/amd/common/BiosCallOuts.h
@@ -53,6 +53,13 @@
 AGESA_STATUS agesa_ReadSpd(UINT32 Func, UINTN Data, VOID *ConfigPtr);
 AGESA_STATUS agesa_ReadSpd_from_cbfs(UINT32 Func, UINTN Data,
 							VOID *ConfigPtr);
+AGESA_STATUS agesa_RunFcnOnAllAps(UINT32 Func, UINTN Data, VOID *ConfigPtr);
+AGESA_STATUS agesa_LateRunApTask(UINT32 Func, UINTN Data, VOID *ConfigPtr);
+AGESA_STATUS agesa_PcieSlotResetControl(UINT32 Func, UINTN Data,
+							VOID *ConfigPtr);
+AGESA_STATUS agesa_WaitForAllApsFinished(UINT32 Func, UINTN Data,
+							VOID *ConfigPtr);
+AGESA_STATUS agesa_IdleAnAp(UINT32 Func, UINTN Data, VOID *ConfigPtr);
 
 AGESA_STATUS GetBiosCallout(UINT32 Func, UINTN Data, VOID *ConfigPtr);
 
diff --git a/src/soc/amd/common/def_callouts.c b/src/soc/amd/common/def_callouts.c
index fda0013..4b71d5b 100644
--- a/src/soc/amd/common/def_callouts.c
+++ b/src/soc/amd/common/def_callouts.c
@@ -144,3 +144,46 @@
 #endif
 	return Status;
 }
+
+AGESA_STATUS agesa_RunFcnOnAllAps(UINT32 Func, UINTN Data, VOID *ConfigPtr)
+{
+	printk(BIOS_WARNING, "Warning - Missing AGESA callout: %s\n", __func__);
+	AGESA_STATUS Status = AGESA_UNSUPPORTED;
+
+	return Status;
+}
+
+AGESA_STATUS agesa_LateRunApTask(UINT32 Func, UINTN Data, VOID *ConfigPtr)
+{
+	printk(BIOS_WARNING, "Warning - Missing AGESA callout: %s\n", __func__);
+	AGESA_STATUS Status = AGESA_UNSUPPORTED;
+
+	return Status;
+}
+
+
+AGESA_STATUS agesa_PcieSlotResetControl(UINT32 Func, UINTN Data,
+	VOID *ConfigPtr)
+{
+	printk(BIOS_WARNING, "Warning - Missing AGESA callout: %s\n", __func__);
+	AGESA_STATUS Status = AGESA_UNSUPPORTED;
+
+	return Status;
+}
+
+AGESA_STATUS agesa_WaitForAllApsFinished(UINT32 Func, UINTN Data,
+	VOID *ConfigPtr)
+{
+	printk(BIOS_WARNING, "Warning - Missing AGESA callout: %s\n", __func__);
+	AGESA_STATUS Status = AGESA_UNSUPPORTED;
+
+	return Status;
+}
+
+AGESA_STATUS agesa_IdleAnAp(UINT32 Func, UINTN Data, VOID *ConfigPtr)
+{
+	printk(BIOS_WARNING, "Warning - Missing AGESA callout: %s\n", __func__);
+	AGESA_STATUS Status = AGESA_UNSUPPORTED;
+
+	return Status;
+}

-- 
To view, visit https://review.coreboot.org/21707
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee5f9c4847a5309a25045fca8c73be4f811c281a
Gerrit-Change-Number: 21707
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170926/2fab0c10/attachment.html>