[coreboot-gerrit] Change in coreboot[master]: mainboard/google/soraka: Reduce Wacom resume time

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/21692 )

Change subject: mainboard/google/soraka: Reduce Wacom resume time
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/21692/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/21692/1//COMMIT_MSG@21
PS1, Line 21: manual testing on Soraka board to ensue that touchscreen works at boot
            : and after suspend/resume.
I think this change should be fine, but I have a few questions:
1. Did you timestamp the two points -- touchscreen device being taken out of reset and the first communication from the driver to the device? Can you please do it over multiple iterations to ensure that the delay is > 100ms?
2. If #1 is true, why even add a delay of 10ms?
3. What happens if suspend fails and system resumes mid-way i.e. suppose touchscreen device is suspended and then system starts resuming without completing the suspend? Can this lead to a race condition?



-- 
To view, visit https://review.coreboot.org/21692
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59d070977a95316414018af69d5b43e3147ccf4e
Gerrit-Change-Number: 21692
Gerrit-PatchSet: 1
Gerrit-Owner: Rajneesh Bhardwaj <rajneesh.bhardwaj at intel.com>
Gerrit-Reviewer: Anshuman Gupta <anshuman.gupta at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Rajat Jain <rajatja at google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Sumeet Pawnikar <sumeet.r.pawnikar at intel.corp-partner.google.com>
Gerrit-Reviewer: Wisley Chen <wisley.chen at quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 26 Sep 2017 12:17:46 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170926/f00ac042/attachment.html>