[coreboot-gerrit] Change in coreboot[master]: asus/p2b-d[s]: Move to EARLY_CBMEM_INIT

Keith Hui (Code Review) gerrit at coreboot.org
Sat Sep 23 07:57:47 CEST 2017


Keith Hui has uploaded this change for review. ( https://review.coreboot.org/21646


Change subject: asus/p2b-d[s]: Move to EARLY_CBMEM_INIT
......................................................................

asus/p2b-d[s]: Move to EARLY_CBMEM_INIT

Boot tested on p2b-ds. Migrate p2b-d as well because they share
the same mainboard romstage.

Change-Id: I3e4b98cc6191d557325fc5da97744902996673af
Signed-off-by: Keith Hui <buurin at gmail.com>
---
M src/mainboard/asus/p2b-d/Kconfig
M src/mainboard/asus/p2b-ds/Kconfig
M src/mainboard/asus/p2b-ds/romstage.c
3 files changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/21646/1

diff --git a/src/mainboard/asus/p2b-d/Kconfig b/src/mainboard/asus/p2b-d/Kconfig
index 8bee3e1..ba2e7e0 100644
--- a/src/mainboard/asus/p2b-d/Kconfig
+++ b/src/mainboard/asus/p2b-d/Kconfig
@@ -18,7 +18,6 @@
 	def_bool y
 	select CPU_INTEL_SLOT_1
 	select NORTHBRIDGE_INTEL_I440BX
-	select LATE_CBMEM_INIT
 	select SOUTHBRIDGE_INTEL_I82371EB
 	select SUPERIO_WINBOND_W83977TF
 	select HAVE_PIRQ_TABLE
diff --git a/src/mainboard/asus/p2b-ds/Kconfig b/src/mainboard/asus/p2b-ds/Kconfig
index 405edca..7d69d1f 100644
--- a/src/mainboard/asus/p2b-ds/Kconfig
+++ b/src/mainboard/asus/p2b-ds/Kconfig
@@ -18,7 +18,6 @@
 	def_bool y
 	select CPU_INTEL_SLOT_1
 	select NORTHBRIDGE_INTEL_I440BX
-	select LATE_CBMEM_INIT
 	select SOUTHBRIDGE_INTEL_I82371EB
 	select SUPERIO_WINBOND_W83977TF
 	select HAVE_PIRQ_TABLE
diff --git a/src/mainboard/asus/p2b-ds/romstage.c b/src/mainboard/asus/p2b-ds/romstage.c
index 1d34bd9..1aa5955 100644
--- a/src/mainboard/asus/p2b-ds/romstage.c
+++ b/src/mainboard/asus/p2b-ds/romstage.c
@@ -24,6 +24,7 @@
 #include <superio/winbond/common/winbond.h>
 #include <superio/winbond/w83977tf/w83977tf.h>
 #include <lib.h>
+#include <cbmem.h>
 
 #define SERIAL_DEV PNP_DEV(0x3f0, W83977TF_SP1)
 
@@ -40,4 +41,5 @@
 
 	enable_smbus();
 	sdram_initialize();
+	cbmem_initialize_empty();
 }

-- 
To view, visit https://review.coreboot.org/21646
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e4b98cc6191d557325fc5da97744902996673af
Gerrit-Change-Number: 21646
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Hui <buurin at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170923/f4d3b542/attachment.html>


More information about the coreboot-gerrit mailing list